From: Wolfram Sang <wsa@the-dreams.de>
To: linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH/RFC] ARM: shmobile: lager: Add I2C2 clock frequency to device tree
Date: Thu, 30 Oct 2014 13:54:18 +0000 [thread overview]
Message-ID: <20141030135417.GD23852@katana> (raw)
In-Reply-To: <1414648520-30184-1-git-send-email-horms+renesas@verge.net.au>
[-- Attachment #1: Type: text/plain, Size: 1310 bytes --]
On Thu, Oct 30, 2014 at 02:55:20PM +0900, Simon Horman wrote:
> From: Ryo Kataoka <ryo.kataoka.wt@renesas.com>
>
> Signed-off-by: Ryo Kataoka <ryo.kataoka.wt@renesas.com>
> [simon: rebased]
> Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
> ---
> Based on the renesas-devel-20141030-v3.18-rc2 branch of my renesas tree
>
> If this is useful I wonder if it is should be set in the lager board DTS
> file instead of the r8a7790 SoC DTSI file.
? This IS set in the .dts and not the .dtsi.
400kHz should never be set in a .dtsi. Not all i2c slave devices support
it. 100kHz is the default which all slaves need to support. But since
I've seen cases where the board needs to lower even further because of
board design issues, I'm getting reluctant to set even 100kHz in dtsi
files in general.
>
>
> arch/arm/boot/dts/r8a7790-lager.dts | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm/boot/dts/r8a7790-lager.dts b/arch/arm/boot/dts/r8a7790-lager.dts
> index 830f2e8..32c7e48 100644
> --- a/arch/arm/boot/dts/r8a7790-lager.dts
> +++ b/arch/arm/boot/dts/r8a7790-lager.dts
> @@ -426,6 +426,7 @@
>
> &iic2 {
> status = "ok";
> + clock-frequency = <400000>;
> pinctrl-0 = <&iic2_pins>;
> pinctrl-names = "default";
>
> --
> 2.1.1
>
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2014-10-30 13:54 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-30 5:55 [PATCH/RFC] ARM: shmobile: lager: Add I2C2 clock frequency to device tree Simon Horman
2014-10-30 13:54 ` Wolfram Sang [this message]
2014-10-31 4:49 ` Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141030135417.GD23852@katana \
--to=wsa@the-dreams.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).