linux-sh.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Wolfram Sang <wsa@the-dreams.de>
To: linux-sh@vger.kernel.org
Subject: Re: [PATCH 07/12] ARM: shmobile: koelsch: fixup overkill I2C2 clock frequency
Date: Fri, 31 Oct 2014 08:07:33 +0000	[thread overview]
Message-ID: <20141031080733.GA1285@katana> (raw)
In-Reply-To: <87r3xo1xak.wl%kuninori.morimoto.gx@gmail.com>

[-- Attachment #1: Type: text/plain, Size: 1008 bytes --]

On Fri, Oct 31, 2014 at 01:02:59AM -0700, Kuninori Morimoto wrote:
> From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
> 
> Current Koelsch I2C2 has 400kHz settings,
> but, ak4643 audio codec chip which is connected to I2C2 can't
> work such frequency.
> Fixup I2C2 clock frequency.

Basically OK, but we should better explicitly set it to 100000 and not
rely on a default coming from somewhere.

> 
> Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
> ---
>  arch/arm/boot/dts/r8a7791-koelsch.dts |    1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/arch/arm/boot/dts/r8a7791-koelsch.dts b/arch/arm/boot/dts/r8a7791-koelsch.dts
> index f722821..1ad9fb3 100644
> --- a/arch/arm/boot/dts/r8a7791-koelsch.dts
> +++ b/arch/arm/boot/dts/r8a7791-koelsch.dts
> @@ -425,7 +425,6 @@
>  	pinctrl-names = "default";
>  
>  	status = "okay";
> -	clock-frequency = <400000>;
>  
>  	composite-in@20 {
>  		compatible = "adi,adv7180";
> -- 
> 1.7.9.5
> 

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

  reply	other threads:[~2014-10-31  8:07 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-10-31  8:02 [PATCH 07/12] ARM: shmobile: koelsch: fixup overkill I2C2 clock frequency Kuninori Morimoto
2014-10-31  8:07 ` Wolfram Sang [this message]
2014-10-31  8:44 ` Kuninori Morimoto
2014-10-31  9:01 ` Simon Horman
2014-11-04  2:14 ` Kuninori Morimoto

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20141031080733.GA1285@katana \
    --to=wsa@the-dreams.de \
    --cc=linux-sh@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).