From: Simon Horman <horms@verge.net.au>
To: linux-sh@vger.kernel.org
Subject: Re: [PATCH 07/12] ARM: shmobile: koelsch: fixup overkill I2C2 clock frequency
Date: Fri, 31 Oct 2014 09:01:07 +0000 [thread overview]
Message-ID: <20141031090105.GF23848@verge.net.au> (raw)
In-Reply-To: <87r3xo1xak.wl%kuninori.morimoto.gx@gmail.com>
On Fri, Oct 31, 2014 at 01:44:35AM -0700, Kuninori Morimoto wrote:
>
> Hi Wolfram, Simon
>
> > > Current Koelsch I2C2 has 400kHz settings,
> > > but, ak4643 audio codec chip which is connected to I2C2 can't
> > > work such frequency.
> > > Fixup I2C2 clock frequency.
> >
> > Basically OK, but we should better explicitly set it to 100000 and not
> > rely on a default coming from somewhere.
>
> OK.
>
> Simon
> Lager board is expecting that I2C is working with 100000 too.
> Can you accept this patch as-is ? if so, I will send
> additional clock frequency 100000 setting patch for both lager/koelsch.
> If not, I will send v2 of this patch-set + lager clock frequency patch.
Could send a small patchset that only fixes up all the clock frequency
problems? That would be easiest for me.
next prev parent reply other threads:[~2014-10-31 9:01 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-31 8:02 [PATCH 07/12] ARM: shmobile: koelsch: fixup overkill I2C2 clock frequency Kuninori Morimoto
2014-10-31 8:07 ` Wolfram Sang
2014-10-31 8:44 ` Kuninori Morimoto
2014-10-31 9:01 ` Simon Horman [this message]
2014-11-04 2:14 ` Kuninori Morimoto
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141031090105.GF23848@verge.net.au \
--to=horms@verge.net.au \
--cc=linux-sh@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).