Re: [PATCH 03/10] ARM: shmobile: r8a7790: Add DU node to device tree

[Simon Horman <horms@verge.net.au>]

[CC Olof]

On Tue, Nov 04, 2014 at 04:12:49PM +0300, Sergei Shtylyov wrote:
> Hello.
> 
> On 11/4/2014 4:50 AM, Simon Horman wrote:
> 
> >From: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
> 
> >Add the DU device with a disabled state. Boards that want to enable the
> >DU need to specify the output topology.
> 
>    OK, but you're also adding VSP1 device node and don't mention that at all.
> Haven't you squashed 2 distinct patches by chance?

Yes, I do appear to have squashed two patches.

Its unclear to me if its worth the delay that respinning this pull-request
would amount to. But I'm happy to do so if that is what Olof would like.

> >Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
> >[horms+renesas@verge.net.au: resolved minor conflict]
> >Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
> >---
> >  arch/arm/boot/dts/r8a7790.dtsi | 90 ++++++++++++++++++++++++++++++++++++++++++
> >  1 file changed, 90 insertions(+)
> 
> >diff --git a/arch/arm/boot/dts/r8a7790.dtsi b/arch/arm/boot/dts/r8a7790.dtsi
> >index d0e1773..b7c59b7 100644
> >--- a/arch/arm/boot/dts/r8a7790.dtsi
> >+++ b/arch/arm/boot/dts/r8a7790.dtsi
> >@@ -600,6 +600,96 @@
> >  		status = "disabled";
> >  	};
> >
> >+	vsp1@fe920000 {
> >+		compatible = "renesas,vsp1";
> >+		reg = <0 0xfe920000 0 0x8000>;
> >+		interrupts = <0 266 IRQ_TYPE_LEVEL_HIGH>;
> >+		clocks = <&mstp1_clks R8A7790_CLK_VSP1_R>;
> >+
> >+		renesas,has-sru;
> >+		renesas,#rpf = <5>;
> >+		renesas,#uds = <1>;
> >+		renesas,#wpf = <4>;
> >+	};
> >+
> >+	vsp1@fe928000 {
> >+		compatible = "renesas,vsp1";
> >+		reg = <0 0xfe928000 0 0x8000>;
> >+		interrupts = <0 267 IRQ_TYPE_LEVEL_HIGH>;
> >+		clocks = <&mstp1_clks R8A7790_CLK_VSP1_S>;
> >+
> >+		renesas,has-lut;
> >+		renesas,has-sru;
> >+		renesas,#rpf = <5>;
> >+		renesas,#uds = <3>;
> >+		renesas,#wpf = <4>;
> >+	};
> >+
> >+	vsp1@fe930000 {
> >+		compatible = "renesas,vsp1";
> >+		reg = <0 0xfe930000 0 0x8000>;
> >+		interrupts = <0 246 IRQ_TYPE_LEVEL_HIGH>;
> >+		clocks = <&mstp1_clks R8A7790_CLK_VSP1_DU0>;
> >+
> >+		renesas,has-lif;
> >+		renesas,has-lut;
> >+		renesas,#rpf = <4>;
> >+		renesas,#uds = <1>;
> >+		renesas,#wpf = <4>;
> >+	};
> >+
> >+	vsp1@fe938000 {
> >+		compatible = "renesas,vsp1";
> >+		reg = <0 0xfe938000 0 0x8000>;
> >+		interrupts = <0 247 IRQ_TYPE_LEVEL_HIGH>;
> >+		clocks = <&mstp1_clks R8A7790_CLK_VSP1_DU1>;
> >+
> >+		renesas,has-lif;
> >+		renesas,has-lut;
> >+		renesas,#rpf = <4>;
> >+		renesas,#uds = <1>;
> >+		renesas,#wpf = <4>;
> >+	};
> [...]
> 
> WBR, Sergei
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-sh" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>