From: Simon Horman <horms@verge.net.au>
To: linux-arm-kernel@lists.infradead.org
Subject: Re: [GIT PULL] Renesas ARM Based SoC Clocks Updates for v3.19
Date: Wed, 05 Nov 2014 04:04:16 +0000 [thread overview]
Message-ID: <20141105040416.GH32470@verge.net.au> (raw)
In-Reply-To: <20141104223054.GB5908@quad.lixom.net>
On Tue, Nov 04, 2014 at 02:30:54PM -0800, Olof Johansson wrote:
> On Wed, Oct 29, 2014 at 01:58:17PM +0900, Simon Horman wrote:
> > Hi Olof, Hi Kevin, Hi Arnd,
> >
> > Please consider these Renesas ARM based SoC clocks updates for v3.19.
> >
> >
> > The following changes since commit f114040e3ea6e07372334ade75d1ee0775c355e1:
> >
> > Linux 3.18-rc1 (2014-10-19 18:08:38 -0700)
> >
> > are available in the git repository at:
> >
> > git://git.kernel.org/pub/scm/linux/kernel/git/horms/renesas.git tags/renesas-clocks-for-v3.19
> >
> > for you to fetch changes up to 2b02b8020fad6ed505ff9cfb1b418c4b59f102a5:
> >
> > ARM: shmobile: r8a7740 legacy: Add missing INTCA clock for irqpin module (2014-10-24 10:30:50 +0900)
> >
> > ----------------------------------------------------------------
> > Renesas ARM Based SoC Clocks Updates for v3.19
> >
> > * Add missing INTCA clock for irqpin module on r8a7740
> >
> > ----------------------------------------------------------------
> > Geert Uytterhoeven (1):
> > ARM: shmobile: r8a7740 legacy: Add missing INTCA clock for irqpin module
>
> Hi,
>
> I'm trying to categorize this patch and it's hard. Is it a fix for a
> bug? Support for new firmware that doesn't enable this clock? How does
> the breakage show itself, and in what circumstances? Essentially, the
> patch description doesn't describe why it's needed and what it fixes.
>
> Which means I don't know where to merge it to.
I believe that this fixes a problem that doesn't manifest.
It ensures that the clock required for the irqpin controller is available.
But as it is in practice the boot loader appears to make the clock
available and its been working due to that for several years. And I'm not
aware of anyone for whom it is not working without this patch.
My personal feeling is that you should just queue it up as a regular
non-bug-fix patch. Sorry for not making that clearer in the first place.
next prev parent reply other threads:[~2014-11-05 4:04 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-29 4:58 [GIT PULL] Renesas ARM Based SoC Clocks Updates for v3.19 Simon Horman
2014-10-29 4:58 ` [PATCH] ARM: shmobile: r8a7740 legacy: Add missing INTCA clock for irqpin module Simon Horman
2014-11-04 22:30 ` [GIT PULL] Renesas ARM Based SoC Clocks Updates for v3.19 Olof Johansson
2014-11-05 4:04 ` Simon Horman [this message]
2014-11-05 8:25 ` Geert Uytterhoeven
2014-11-05 9:11 ` Geert Uytterhoeven
2014-11-05 19:14 ` Olof Johansson
2014-11-05 21:01 ` Geert Uytterhoeven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141105040416.GH32470@verge.net.au \
--to=horms@verge.net.au \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox