From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jason Cooper Date: Tue, 11 Nov 2014 22:58:00 +0000 Subject: Re: [PATCH] irqchip: atmel-aic: fix irqdomain initialization Message-Id: <20141111225800.GE3698@titan.lakedaemon.net> List-Id: References: <20141110230301.GV4068@piout.net> <1415712816-9202-1-git-send-email-boris.brezillon@free-electrons.com> In-Reply-To: <1415712816-9202-1-git-send-email-boris.brezillon@free-electrons.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Boris Brezillon Cc: Kevin Cernekee , Alexandre Belloni , Kevin Hilman , Thomas Gleixner , linux-sh@vger.kernel.org, Florian Fainelli , Ralf Baechle , Sergei Shtylyov , linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, Maxime Bizon , Jonas Gorski , linux-mips@linux-mips.org, Nicolas Ferre , Olof Johansson , Arnd Bergmann On Tue, Nov 11, 2014 at 02:33:36PM +0100, Boris Brezillon wrote: > First of all IRQCHIP_SKIP_SET_WAKE is not a valid irq_gc_flags and thus > should not be passed as the last argument of > irq_alloc_domain_generic_chips. > > Then pass the correct handler (handle_fasteoi_irq) to > irq_alloc_domain_generic_chips instead of manually re-setting it in the > initialization loop. > > And eventually initialize default irq flags to the pseudo standard: > IRQ_REQUEST | IRQ_PROBE | IRQ_AUTOEN. > > Signed-off-by: Boris Brezillon > --- > Hello Kevin, > > This patch has not been tested yet but it should solve the issue you've > experienced with the IRQ_GC_BE_IO flag and the atmel-aic driver. > > I'll test it tomorrow and let you know if it actually works. > > Regards, > > Boris > > drivers/irqchip/irq-atmel-aic-common.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) Applied to irqchip/urgent with Kevin's Tested-by. Also, flagged for stable, v3.17 and up. Boris, once this is in mainline, you may want to generate a patch against older versions (in the arch dir) for the stable team. thx, Jason.