* [PATCH/RFC] ARM: shmobile: lager: Fix node name of GPIO keys
@ 2014-10-30 5:56 Simon Horman
2014-10-30 9:48 ` Geert Uytterhoeven
2014-10-30 11:33 ` Sergei Shtylyov
0 siblings, 2 replies; 4+ messages in thread
From: Simon Horman @ 2014-10-30 5:56 UTC (permalink / raw)
To: linux-arm-kernel
From: Koji Matsuoka <koji.matsuoka.xm@renesas.com>
gpio_keys appears to be consistent with more dts files than gpio-keys
Signed-off-by: Koji Matsuoka <koji.matsuoka.xm@renesas.com>
[simon: reworded changelog]
Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
---
Based on the renesas-devel-20141030-v3.18-rc2 branch of my renesas tree
arch/arm/boot/dts/r8a7790-lager.dts | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/boot/dts/r8a7790-lager.dts b/arch/arm/boot/dts/r8a7790-lager.dts
index 830f2e8..6c05644 100644
--- a/arch/arm/boot/dts/r8a7790-lager.dts
+++ b/arch/arm/boot/dts/r8a7790-lager.dts
@@ -43,7 +43,7 @@
#size-cells = <1>;
};
- gpio_keys {
+ gpio-keys {
compatible = "gpio-keys";
button@1 {
--
2.1.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH/RFC] ARM: shmobile: lager: Fix node name of GPIO keys
2014-10-30 5:56 [PATCH/RFC] ARM: shmobile: lager: Fix node name of GPIO keys Simon Horman
@ 2014-10-30 9:48 ` Geert Uytterhoeven
2014-11-12 8:31 ` Simon Horman
2014-10-30 11:33 ` Sergei Shtylyov
1 sibling, 1 reply; 4+ messages in thread
From: Geert Uytterhoeven @ 2014-10-30 9:48 UTC (permalink / raw)
To: linux-arm-kernel
On Thu, Oct 30, 2014 at 6:56 AM, Simon Horman
<horms+renesas@verge.net.au> wrote:
> From: Koji Matsuoka <koji.matsuoka.xm@renesas.com>
>
> gpio_keys appears to be consistent with more dts files than gpio-keys
The closest match on page 17 of ePAPR is "keyboard".
Should we use that?
https://www.power.org/wp-content/uploads/2012/06/Power_ePAPR_APPROVED_v1.1.pdf
> Signed-off-by: Koji Matsuoka <koji.matsuoka.xm@renesas.com>
> [simon: reworded changelog]
> Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
> ---
> Based on the renesas-devel-20141030-v3.18-rc2 branch of my renesas tree
>
> arch/arm/boot/dts/r8a7790-lager.dts | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/boot/dts/r8a7790-lager.dts b/arch/arm/boot/dts/r8a7790-lager.dts
> index 830f2e8..6c05644 100644
> --- a/arch/arm/boot/dts/r8a7790-lager.dts
> +++ b/arch/arm/boot/dts/r8a7790-lager.dts
> @@ -43,7 +43,7 @@
> #size-cells = <1>;
> };
>
> - gpio_keys {
> + gpio-keys {
> compatible = "gpio-keys";
>
> button@1 {
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH/RFC] ARM: shmobile: lager: Fix node name of GPIO keys
2014-10-30 9:48 ` Geert Uytterhoeven
@ 2014-11-12 8:31 ` Simon Horman
0 siblings, 0 replies; 4+ messages in thread
From: Simon Horman @ 2014-11-12 8:31 UTC (permalink / raw)
To: linux-arm-kernel
On Thu, Oct 30, 2014 at 10:48:33AM +0100, Geert Uytterhoeven wrote:
> On Thu, Oct 30, 2014 at 6:56 AM, Simon Horman
> <horms+renesas@verge.net.au> wrote:
> > From: Koji Matsuoka <koji.matsuoka.xm@renesas.com>
> >
> > gpio_keys appears to be consistent with more dts files than gpio-keys
>
> The closest match on page 17 of ePAPR is "keyboard".
> Should we use that?
>
> https://www.power.org/wp-content/uploads/2012/06/Power_ePAPR_APPROVED_v1.1.pdf
Sure. I will do a sweep to update that for all our boards.
> > [simon: reworded changelog]
> > Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
> > ---
> > Based on the renesas-devel-20141030-v3.18-rc2 branch of my renesas tree
> >
> > arch/arm/boot/dts/r8a7790-lager.dts | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/arch/arm/boot/dts/r8a7790-lager.dts b/arch/arm/boot/dts/r8a7790-lager.dts
> > index 830f2e8..6c05644 100644
> > --- a/arch/arm/boot/dts/r8a7790-lager.dts
> > +++ b/arch/arm/boot/dts/r8a7790-lager.dts
> > @@ -43,7 +43,7 @@
> > #size-cells = <1>;
> > };
> >
> > - gpio_keys {
> > + gpio-keys {
> > compatible = "gpio-keys";
> >
> > button@1 {
>
> Gr{oetje,eeting}s,
>
> Geert
>
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
>
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like that.
> -- Linus Torvalds
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH/RFC] ARM: shmobile: lager: Fix node name of GPIO keys
2014-10-30 5:56 [PATCH/RFC] ARM: shmobile: lager: Fix node name of GPIO keys Simon Horman
2014-10-30 9:48 ` Geert Uytterhoeven
@ 2014-10-30 11:33 ` Sergei Shtylyov
1 sibling, 0 replies; 4+ messages in thread
From: Sergei Shtylyov @ 2014-10-30 11:33 UTC (permalink / raw)
To: linux-arm-kernel
Hello.
On 10/30/2014 8:56 AM, Simon Horman wrote:
> From: Koji Matsuoka <koji.matsuoka.xm@renesas.com>
> gpio_keys appears to be consistent with more dts files than gpio-keys
Vice versa, I guess if you're changing underscore to hyphen?
> Signed-off-by: Koji Matsuoka <koji.matsuoka.xm@renesas.com>
> [simon: reworded changelog]
> Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
> ---
> Based on the renesas-devel-20141030-v3.18-rc2 branch of my renesas tree
> arch/arm/boot/dts/r8a7790-lager.dts | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
> diff --git a/arch/arm/boot/dts/r8a7790-lager.dts b/arch/arm/boot/dts/r8a7790-lager.dts
> index 830f2e8..6c05644 100644
> --- a/arch/arm/boot/dts/r8a7790-lager.dts
> +++ b/arch/arm/boot/dts/r8a7790-lager.dts
> @@ -43,7 +43,7 @@
> #size-cells = <1>;
> };
>
> - gpio_keys {
> + gpio-keys {
> compatible = "gpio-keys";
WBR, Sergei
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2014-11-12 8:31 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-10-30 5:56 [PATCH/RFC] ARM: shmobile: lager: Fix node name of GPIO keys Simon Horman
2014-10-30 9:48 ` Geert Uytterhoeven
2014-11-12 8:31 ` Simon Horman
2014-10-30 11:33 ` Sergei Shtylyov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).