linux-sh.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Russell King - ARM Linux <linux@arm.linux.org.uk>
To: linux-arm-kernel@lists.infradead.org
Subject: Re: ARM: shmobile: sh73a0: CPU1 failed to come online (Re: [PATCH 0/4] ARM: shmobile: r8a7740/armadi
Date: Mon, 17 Nov 2014 15:12:41 +0000	[thread overview]
Message-ID: <20141117151241.GR4042@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <CAMuHMdWyUJ81G2CLpYScm9qB0KMia0PReBQ8oXdu+Z2P6AWWNg@mail.gmail.com>

On Mon, Nov 17, 2014 at 02:57:46PM +0100, Geert Uytterhoeven wrote:
> I tried to convert sh73a0, but it doesn't work, due to problems
> bringing up the second
> CPU core.
> 
> Details:
>   - l2x0_of_init() is called much earlier than l2x0_init().
>     When the L2 cache is enabled, initialization of the second CPU core of
>     sh73a0 (Dual-core Cortex-A9) fails.

Missing L2 cache flushes for (any) the secondary core data/trampoline?

>   - As jiffies are not yet incrementing at that point (they are on r8a7791?),
>     timeouts don't work, and the kernel hangs at the
>     wait_for_completion_timeout() call in arch/arm/kernel/smp.c:__cpu_up().

That sounds bad:

start_kernel() -> rest_init() -> kernel_thread(kernel_init)

kernel_init() -> kernel_init_freeable() -> smp_init() -> (for each CPU) cpu_up()

By the time we get to rest_init(), init_IRQ(), time_init(),
local_irq_enable(), late_time_init(), calibrate_delay(), etc have all
been called, so if jiffies is not incrementing in __cpu_up(), that's
a big problem.

-- 
FTTC broadband for 0.8mile line: currently at 9.5Mbps down 400kbps up
according to speedtest.net.

  reply	other threads:[~2014-11-17 15:12 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-11-17 13:57 ARM: shmobile: sh73a0: CPU1 failed to come online (Re: [PATCH 0/4] ARM: shmobile: r8a7740/armadillo: Geert Uytterhoeven
2014-11-17 15:12 ` Russell King - ARM Linux [this message]
2015-01-13  9:41   ` ARM: shmobile: sh73a0: CPU1 failed to come online (Re: [PATCH 0/4] ARM: shmobile: r8a7740/armadi Geert Uytterhoeven

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20141117151241.GR4042@n2100.arm.linux.org.uk \
    --to=linux@arm.linux.org.uk \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).