linux-sh.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH 0/2] ARM: shmobile: R-mobile: Fix SYSC register lengths
@ 2014-12-04 12:31 Geert Uytterhoeven
  2014-12-04 12:31 ` [PATCH 1/2] PM / Domains: R-Mobile SYSC: Add missing 0x prefixes to example Geert Uytterhoeven
                   ` (2 more replies)
  0 siblings, 3 replies; 4+ messages in thread
From: Geert Uytterhoeven @ 2014-12-04 12:31 UTC (permalink / raw)
  To: Simon Horman, Magnus Damm; +Cc: linux-pm, linux-sh, Geert Uytterhoeven

	Hi Simon, Magnus,

This patch series fixes the register lengths of the SYSC device nodes, by
adding the missing 0x prefixes. They were really intended to be 0x8000, not
8000.
This doesn't cause any problems for now, but at least the second range
is documented to cover the full 32 KiB on R-Mobile A1 (r8a7740).
Sorry for not noticing before.

Perhaps these can still be folded into the commits that introduced the bugs?
  - commit 0f3dad1d6c519ddf ("PM / Domains: Add DT bindings for the R-Mobile
    System Controller"),
  - commit 2f49e6f2721c4344 ("ARM: shmobile: r8a7740 dtsi: Add PM domain
    support").

Thanks!

Geert Uytterhoeven (2):
  PM / Domains: R-Mobile SYSC: Add missing 0x prefixes to example
  ARM: shmobile: r8a7740 dtsi: Add missing 0x prefix to SYSC reg lengths

 Documentation/devicetree/bindings/power/renesas,sysc-rmobile.txt | 2 +-
 arch/arm/boot/dts/r8a7740.dtsi                                   | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

-- 
1.9.1

Gr{oetje,eeting}s,

						Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
							    -- Linus Torvalds

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [PATCH 1/2] PM / Domains: R-Mobile SYSC: Add missing 0x prefixes to example
  2014-12-04 12:31 [PATCH 0/2] ARM: shmobile: R-mobile: Fix SYSC register lengths Geert Uytterhoeven
@ 2014-12-04 12:31 ` Geert Uytterhoeven
  2014-12-04 12:31 ` [PATCH 2/2] ARM: shmobile: r8a7740 dtsi: Add missing 0x prefix to SYSC reg lengths Geert Uytterhoeven
  2014-12-05  0:13 ` [PATCH 0/2] ARM: shmobile: R-mobile: Fix SYSC register lengths Simon Horman
  2 siblings, 0 replies; 4+ messages in thread
From: Geert Uytterhoeven @ 2014-12-04 12:31 UTC (permalink / raw)
  To: Simon Horman, Magnus Damm; +Cc: linux-pm, linux-sh, Geert Uytterhoeven

The register lengths in the example were supposed to be 0x8000, not
8000.
This doesn't cause any problems for now, but at least the second range
is documented to cover the full 32 KiB on R-Mobile A1 (r8a7740).

Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
 Documentation/devicetree/bindings/power/renesas,sysc-rmobile.txt | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Documentation/devicetree/bindings/power/renesas,sysc-rmobile.txt b/Documentation/devicetree/bindings/power/renesas,sysc-rmobile.txt
index 5887cbae313481cc..2460476808e9333e 100644
--- a/Documentation/devicetree/bindings/power/renesas,sysc-rmobile.txt
+++ b/Documentation/devicetree/bindings/power/renesas,sysc-rmobile.txt
@@ -53,7 +53,7 @@ which is a subdomain of A4S.
 
 	sysc: system-controller@e6180000 {
 		compatible = "renesas,sysc-r8a7740", "renesas,sysc-rmobile";
-		reg = <0xe6180000 8000>, <0xe6188000 8000>;
+		reg = <0xe6180000 0x8000>, <0xe6188000 0x8000>;
 
 		pm-domains {
 			pd_c5: c5 {
-- 
1.9.1


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* [PATCH 2/2] ARM: shmobile: r8a7740 dtsi: Add missing 0x prefix to SYSC reg lengths
  2014-12-04 12:31 [PATCH 0/2] ARM: shmobile: R-mobile: Fix SYSC register lengths Geert Uytterhoeven
  2014-12-04 12:31 ` [PATCH 1/2] PM / Domains: R-Mobile SYSC: Add missing 0x prefixes to example Geert Uytterhoeven
@ 2014-12-04 12:31 ` Geert Uytterhoeven
  2014-12-05  0:13 ` [PATCH 0/2] ARM: shmobile: R-mobile: Fix SYSC register lengths Simon Horman
  2 siblings, 0 replies; 4+ messages in thread
From: Geert Uytterhoeven @ 2014-12-04 12:31 UTC (permalink / raw)
  To: Simon Horman, Magnus Damm; +Cc: linux-pm, linux-sh, Geert Uytterhoeven

The register lengths of the sysc device node were supposed to be 0x8000,
not 8000.
This doesn't cause any problems for now, but at least the second range
is documented to cover the full 32 KiB.

Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
 arch/arm/boot/dts/r8a7740.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm/boot/dts/r8a7740.dtsi b/arch/arm/boot/dts/r8a7740.dtsi
index 95723764431a3e5d..52f2cf4b84d3ccb4 100644
--- a/arch/arm/boot/dts/r8a7740.dtsi
+++ b/arch/arm/boot/dts/r8a7740.dtsi
@@ -578,7 +578,7 @@
 
 	sysc: system-controller@e6180000 {
 		compatible = "renesas,sysc-r8a7740", "renesas,sysc-rmobile";
-		reg = <0xe6180000 8000>, <0xe6188000 8000>;
+		reg = <0xe6180000 0x8000>, <0xe6188000 0x8000>;
 
 		pm-domains {
 			pd_c5: c5 {
-- 
1.9.1


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH 0/2] ARM: shmobile: R-mobile: Fix SYSC register lengths
  2014-12-04 12:31 [PATCH 0/2] ARM: shmobile: R-mobile: Fix SYSC register lengths Geert Uytterhoeven
  2014-12-04 12:31 ` [PATCH 1/2] PM / Domains: R-Mobile SYSC: Add missing 0x prefixes to example Geert Uytterhoeven
  2014-12-04 12:31 ` [PATCH 2/2] ARM: shmobile: r8a7740 dtsi: Add missing 0x prefix to SYSC reg lengths Geert Uytterhoeven
@ 2014-12-05  0:13 ` Simon Horman
  2 siblings, 0 replies; 4+ messages in thread
From: Simon Horman @ 2014-12-05  0:13 UTC (permalink / raw)
  To: Geert Uytterhoeven; +Cc: Magnus Damm, linux-pm, linux-sh

On Thu, Dec 04, 2014 at 01:31:36PM +0100, Geert Uytterhoeven wrote:
> 	Hi Simon, Magnus,
> 
> This patch series fixes the register lengths of the SYSC device nodes, by
> adding the missing 0x prefixes. They were really intended to be 0x8000, not
> 8000.
> This doesn't cause any problems for now, but at least the second range
> is documented to cover the full 32 KiB on R-Mobile A1 (r8a7740).
> Sorry for not noticing before.
> 
> Perhaps these can still be folded into the commits that introduced the bugs?
>   - commit 0f3dad1d6c519ddf ("PM / Domains: Add DT bindings for the R-Mobile
>     System Controller"),
>   - commit 2f49e6f2721c4344 ("ARM: shmobile: r8a7740 dtsi: Add PM domain
>     support").
> 
> Thanks!
> 
> Geert Uytterhoeven (2):
>   PM / Domains: R-Mobile SYSC: Add missing 0x prefixes to example
>   ARM: shmobile: r8a7740 dtsi: Add missing 0x prefix to SYSC reg lengths
> 
>  Documentation/devicetree/bindings/power/renesas,sysc-rmobile.txt | 2 +-
>  arch/arm/boot/dts/r8a7740.dtsi                                   | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)

Thanks Geert,

I will squash these changes into the patches that added the problems.

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2014-12-05  0:13 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-12-04 12:31 [PATCH 0/2] ARM: shmobile: R-mobile: Fix SYSC register lengths Geert Uytterhoeven
2014-12-04 12:31 ` [PATCH 1/2] PM / Domains: R-Mobile SYSC: Add missing 0x prefixes to example Geert Uytterhoeven
2014-12-04 12:31 ` [PATCH 2/2] ARM: shmobile: r8a7740 dtsi: Add missing 0x prefix to SYSC reg lengths Geert Uytterhoeven
2014-12-05  0:13 ` [PATCH 0/2] ARM: shmobile: R-mobile: Fix SYSC register lengths Simon Horman

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).