From: Simon Horman <horms@verge.net.au>
To: linux-sh@vger.kernel.org
Subject: Re: [PATCH] ARM: shmobile: ape6evm: Fix LAN9220 VDDVARIO voltage
Date: Wed, 17 Dec 2014 00:26:55 +0000 [thread overview]
Message-ID: <20141217002655.GF23321@verge.net.au> (raw)
In-Reply-To: <1418771845-12191-1-git-send-email-laurent.pinchart+renesas@ideasonboard.com>
On Wed, Dec 17, 2014 at 01:17:25AM +0200, Laurent Pinchart wrote:
> The LAN9220 VDDVARIO supply is powered by a 1.8V source, not 3.3V. Fix
> it in the device tree.
>
> Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
> ---
> arch/arm/boot/dts/r8a73a4-ape6evm.dts | 14 +++++++++++---
> 1 file changed, 11 insertions(+), 3 deletions(-)
>
> This patch is based on top of Ulrich's "[PATCH v2 0/7] ARM: shmobile: ape6evm:
> multiplatform support" series, but it could easily be rebased to apply without
> that dependency.
My preference is to take this fix before Ulrich's series.
But I am happy to negotiate if others have a different preference.
>
> diff --git a/arch/arm/boot/dts/r8a73a4-ape6evm.dts b/arch/arm/boot/dts/r8a73a4-ape6evm.dts
> index 6b7bc1fb842e..0d50bef01234 100644
> --- a/arch/arm/boot/dts/r8a73a4-ape6evm.dts
> +++ b/arch/arm/boot/dts/r8a73a4-ape6evm.dts
> @@ -55,8 +55,16 @@
> enable-active-high;
> };
>
> - /* Common 3.3V rail, used by several devices on APE6EVM */
> - ape6evm_fixed_3v3: regulator@2 {
> + /* Common 1.8V and 3.3V rails, used by several devices on APE6EVM */
> + ape6evm_fixed_1v8: regulator@2 {
> + compatible = "regulator-fixed";
> + regulator-name = "1V8";
> + regulator-min-microvolt = <1800000>;
> + regulator-max-microvolt = <1800000>;
> + regulator-always-on;
> + };
> +
> + ape6evm_fixed_3v3: regulator@3 {
> compatible = "regulator-fixed";
> regulator-name = "3V3";
> regulator-min-microvolt = <3300000>;
> @@ -80,7 +88,7 @@
> smsc,irq-active-high;
> smsc,irq-push-pull;
> vdd33a-supply = <&ape6evm_fixed_3v3>;
> - vddvario-supply = <&ape6evm_fixed_3v3>;
> + vddvario-supply = <&ape6evm_fixed_1v8>;
> };
> };
>
> --
> Regards,
>
> Laurent Pinchart
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-sh" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
next prev parent reply other threads:[~2014-12-17 0:26 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-16 23:17 [PATCH] ARM: shmobile: ape6evm: Fix LAN9220 VDDVARIO voltage Laurent Pinchart
2014-12-17 0:26 ` Simon Horman [this message]
2014-12-17 0:30 ` Laurent Pinchart
2014-12-18 0:43 ` Simon Horman
2014-12-18 2:30 ` Laurent Pinchart
2014-12-19 0:11 ` Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141217002655.GF23321@verge.net.au \
--to=horms@verge.net.au \
--cc=linux-sh@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox