SUPERH platform development
 help / color / mirror / Atom feed
From: Felipe Balbi <balbi@ti.com>
To: linux-sh@vger.kernel.org
Subject: Re: [PATCH v2] renesas_usbhs: fix platform init error message
Date: Wed, 24 Dec 2014 00:40:38 +0000	[thread overview]
Message-ID: <20141224004038.GG32702@saruman> (raw)
In-Reply-To: <5384843.KGcHOMgQLi@wasted.cogentembedded.com>

[-- Attachment #1: Type: text/plain, Size: 1852 bytes --]

On Tue, Dec 23, 2014 at 10:41:49PM +0300, Sergei Shtylyov wrote:
> Hello.
> 
> On 12/23/2014 10:17 PM, Felipe Balbi wrote:
> 
> [...]
> 
> >>>>>>>>>There is a typo ("prove" instead of "probe") in the error message printed when
> >>>>>>>>>the platform initialization fails. Replace that word with more fitting "init".
> 
> >>>>>>>>>Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
> 
> >>>>>>>>this actually goes through me, I'll take it in a bit.
> 
> >>>>>>>     Er, OK. Could you update MAINTAINERS?
> 
> >>>>>>there is no entry for renesas driver in MAINTAINERS.
> 
> >>>>>>Shimoda-san, care to send a patch adding yourself or Morimoto-san as
> >>>>>>maintainers for Renesas driver and pointing to my tree in kernel.org ?
> 
> >>>>>I would like to move the renesas_usbhs driver to drivers/usb/gadget/udc somehow.
> >>>>>Because the driver is almost used for a gadget driver.
> >>>>>The driver has a host driver support now. But, it is not used recently.
> 
> >>>>>After that, this MAINTAINERS issue becomes clear, I think.
> >>>>>Felipe-san and Sergei-san, what do you think?
> 
> >>>>     I'm against such move.
> 
> >>>Thank you for the reply. But, I would like to know why you are against such move.
> 
> >>    Because we still need the host mode; RZ/A1H (R7S72100) SoC should need it
> >>soon), and bi-modal USBHS hardware is better placed in its own directory.
> 
> >yeah, I'll agree with Sergei here. All other dual role IPs have their
> 
>    Thanks. :-)
> 
> >own directories (musb, dwc3, dwc2, isp1760, chipidea...).
> 
>    However, I'm only seeing ISP1760 files in drivers/usb/host/...

There are patches pending :-) But now that I look at it, Laurent added
peripheral support but kept the thing under drivers/usb/host. I asked
him to move it out from there.

-- 
balbi

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

  parent reply	other threads:[~2014-12-24  0:40 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-11-04 22:48 [PATCH v2] renesas_usbhs: fix platform init error message Sergei Shtylyov
2014-11-04 22:53 ` Felipe Balbi
2014-11-04 22:55 ` Sergei Shtylyov
2014-11-04 23:01 ` Felipe Balbi
2014-12-12 19:45 ` Sergei Shtylyov
2014-12-18  1:46 ` yoshihiro shimoda
2014-12-18 11:31 ` Sergei Shtylyov
2014-12-19  1:33 ` yoshihiro shimoda
2014-12-19 12:46 ` Sergei Shtylyov
2014-12-23 19:16 ` Felipe Balbi
2014-12-23 19:17 ` Felipe Balbi
2014-12-23 19:41 ` Sergei Shtylyov
2014-12-24  0:40 ` Felipe Balbi [this message]
2014-12-24 10:02 ` yoshihiro shimoda
2015-01-05 11:50 ` Geert Uytterhoeven
2015-01-06  8:20 ` yoshihiro shimoda

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20141224004038.GG32702@saruman \
    --to=balbi@ti.com \
    --cc=linux-sh@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox