From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Paul E. McKenney" Date: Wed, 07 Jan 2015 21:04:19 +0000 Subject: Re: [PATCH] next: sh: Fix compile error Message-Id: <20150107210419.GH5280@linux.vnet.ibm.com> List-Id: References: <1420662748-28129-1-git-send-email-linux@roeck-us.net> In-Reply-To: <1420662748-28129-1-git-send-email-linux@roeck-us.net> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Guenter Roeck Cc: linux-sh@vger.kernel.org, linux-kernel@vger.kernel.org, Christian Borntraeger On Wed, Jan 07, 2015 at 12:32:28PM -0800, Guenter Roeck wrote: > Commit a91ed664749c ("kernel: tighten rules for ACCESS ONCE") results in a > compile failure for sh builds with CONFIG_X2TLB enabled. > > arch/sh/mm/gup.c: In function 'gup_get_pte': > arch/sh/mm/gup.c:20:2: error: invalid initializer > make[1]: *** [arch/sh/mm/gup.o] Error 1 > > Replace ACCESS_ONCE with READ_ONCE to fix the problem. > > Fixes: a91ed664749c ("kernel: tighten rules for ACCESS ONCE") > Cc: Paul E. McKenney Reviewed-by: Paul E. McKenney > Cc: Christian Borntraeger > Signed-off-by: Guenter Roeck > --- > Compile tested only. > > arch/sh/mm/gup.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/sh/mm/gup.c b/arch/sh/mm/gup.c > index 37458f3..e113bb4 100644 > --- a/arch/sh/mm/gup.c > +++ b/arch/sh/mm/gup.c > @@ -17,7 +17,7 @@ > static inline pte_t gup_get_pte(pte_t *ptep) > { > #ifndef CONFIG_X2TLB > - return ACCESS_ONCE(*ptep); > + return READ_ONCE(*ptep); > #else > /* > * With get_user_pages_fast, we walk down the pagetables without > -- > 2.1.0 >