From: Simon Horman <horms@verge.net.au>
To: linux-sh@vger.kernel.org
Subject: Re: ARM: shmobile: r8a7778: Instantiate GIC from C board code in legacy builds
Date: Sat, 17 Jan 2015 00:32:18 +0000 [thread overview]
Message-ID: <20150117003215.GA15403@verge.net.au> (raw)
In-Reply-To: <20150116011710.12605.71607.sendpatchset@little-apple>
On Fri, Jan 16, 2015 at 10:20:38AM +0100, Geert Uytterhoeven wrote:
> On Fri, Jan 16, 2015 at 2:17 AM, Magnus Damm <magnus.damm@gmail.com> wrote:
> > From: Magnus Damm <damm+renesas@opensource.se>
> >
> > As of commit 9a1091ef0017c40a ("irqchip: gic: Support hierarchy irq
> > domain."), Bock-W legacy hangs during boot with:
> >
> > Unable to handle kernel paging request at virtual address cf86a128
> > pgd = c0004000
> > [cf86a128] *pgdo80041e(bad)
> > Internal error: Oops: 8000000d [#1] SMP ARM
> > CPU: 0 PID: 1 Comm: swapper/0 Not tainted 3.19.0-rc4 #1
> > Hardware name: bockw
> > task: cf823b40 ti: cf824000 task.ti: cf824000
> > PC is at 0xcf86a128
> > LR is at request_threaded_irq+0xbc/0x124
> >
> > This happens because the IRQ numbers of the GIC are now virtual, and no
> > longer match the hardcoded hardware IRQ numbers in the platform board
> > code.
> >
> > To fix this, instantiate the GIC from platform board code when compiling
> > a legacy kernel, like is done for the sh73a0 and r8a7740 legacy code.
> >
> > Follows same style as the r8a7740 legacy GIC fix by Geert Uytterhoeven,
> > thanks to him for the initial work.
> >
> > Signed-off-by: Magnus Damm <damm+renesas@opensource.se>
>
> Acked-by: Geert Uytterhoeven <geert+renesas@glider.be>
Thanks, its nice to see this fixed :)
I have queued up this and the similar patch for the r8a7779 as fixes for
v3.19.
I believe that now it is only the r8a73a4 that is left needing this problem
resolved. As I have access to that hardware I'm happy to help with any
work in that area.
prev parent reply other threads:[~2015-01-17 0:32 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-16 1:17 ARM: shmobile: r8a7778: Instantiate GIC from C board code in legacy builds Magnus Damm
2015-01-16 9:20 ` Geert Uytterhoeven
2015-01-17 0:32 ` Simon Horman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150117003215.GA15403@verge.net.au \
--to=horms@verge.net.au \
--cc=linux-sh@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox