* Re: [PATCH] dmaengine: rcar-hpbdma: tidyup residue_granularity
2015-01-21 4:42 [PATCH] dmaengine: rcar-hpbdma: tidyup residue_granularity Kuninori Morimoto
@ 2015-01-21 11:07 ` Laurent Pinchart
2015-01-22 0:24 ` Kuninori Morimoto
` (3 subsequent siblings)
4 siblings, 0 replies; 6+ messages in thread
From: Laurent Pinchart @ 2015-01-21 11:07 UTC (permalink / raw)
To: linux-sh
Hi Morimoto-san,
Thank you for the patch.
On Wednesday 21 January 2015 04:42:22 Kuninori Morimoto wrote:
> From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
>
> The driver doesn't support residue reporting at all.
> residue_granularity should be set to DMA_RESIDUE_GRANULARITY_DESCRIPTOR.
> Special thanks to Laurent
>
> Reported-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
I thought the plan was to fix this in v4 of "[PATCH v3] dmaengine:: rcar-
hpbdma: add dma_dev->directions" ?
> ---
> drivers/dma/sh/rcar-hpbdma.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/dma/sh/rcar-hpbdma.c b/drivers/dma/sh/rcar-hpbdma.c
> index 6fef1b9..749f26e 100644
> --- a/drivers/dma/sh/rcar-hpbdma.c
> +++ b/drivers/dma/sh/rcar-hpbdma.c
> @@ -600,7 +600,7 @@ static int hpb_dmae_probe(struct platform_device *pdev)
> dma_dev->src_addr_widths = widths;
> dma_dev->dst_addr_widths = widths;
> dma_dev->directions = BIT(DMA_MEM_TO_DEV) | BIT(DMA_DEV_TO_MEM);
> - dma_dev->residue_granularity = DMA_RESIDUE_GRANULARITY_BURST;
> + dma_dev->residue_granularity = DMA_RESIDUE_GRANULARITY_DESCRIPTOR;
>
> hpbdev->shdma_dev.ops = &hpb_dmae_ops;
> hpbdev->shdma_dev.desc_size = sizeof(struct hpb_desc);
--
Regards,
Laurent Pinchart
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] dmaengine: rcar-hpbdma: tidyup residue_granularity
2015-01-21 4:42 [PATCH] dmaengine: rcar-hpbdma: tidyup residue_granularity Kuninori Morimoto
2015-01-21 11:07 ` Laurent Pinchart
@ 2015-01-22 0:24 ` Kuninori Morimoto
2015-01-22 0:28 ` Laurent Pinchart
` (2 subsequent siblings)
4 siblings, 0 replies; 6+ messages in thread
From: Kuninori Morimoto @ 2015-01-22 0:24 UTC (permalink / raw)
To: linux-sh
Hi Laurent
> > From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
> >
> > The driver doesn't support residue reporting at all.
> > residue_granularity should be set to DMA_RESIDUE_GRANULARITY_DESCRIPTOR.
> > Special thanks to Laurent
> >
> > Reported-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> > Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
>
> I thought the plan was to fix this in v4 of "[PATCH v3] dmaengine:: rcar-
> hpbdma: add dma_dev->directions" ?
Yes, I had same plan, but, it seems that dma/next branch already had
previous patch. so, I sent additional patch
I'm happy to create v4 patch of course.
=> Vinod ?
Best regards
---
Kuninori Morimoto
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] dmaengine: rcar-hpbdma: tidyup residue_granularity
2015-01-21 4:42 [PATCH] dmaengine: rcar-hpbdma: tidyup residue_granularity Kuninori Morimoto
2015-01-21 11:07 ` Laurent Pinchart
2015-01-22 0:24 ` Kuninori Morimoto
@ 2015-01-22 0:28 ` Laurent Pinchart
2015-01-26 6:38 ` Vinod Koul
2015-01-26 6:52 ` Kuninori Morimoto
4 siblings, 0 replies; 6+ messages in thread
From: Laurent Pinchart @ 2015-01-22 0:28 UTC (permalink / raw)
To: linux-sh
Hi Morimoto-san,
On Thursday 22 January 2015 00:24:05 Kuninori Morimoto wrote:
> >> From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
> >>
> >> The driver doesn't support residue reporting at all.
> >> residue_granularity should be set to DMA_RESIDUE_GRANULARITY_DESCRIPTOR.
> >> Special thanks to Laurent
> >>
> >> Reported-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> >> Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
> >
> > I thought the plan was to fix this in v4 of "[PATCH v3] dmaengine:: rcar-
> > hpbdma: add dma_dev->directions" ?
>
> Yes, I had same plan, but, it seems that dma/next branch already had
> previous patch. so, I sent additional patch
>
> I'm happy to create v4 patch of course.
> => Vinod ?
Just for the record, if the base patch has already been merged, I'm totally
fine with a separate patch.
--
Regards,
Laurent Pinchart
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] dmaengine: rcar-hpbdma: tidyup residue_granularity
2015-01-21 4:42 [PATCH] dmaengine: rcar-hpbdma: tidyup residue_granularity Kuninori Morimoto
` (2 preceding siblings ...)
2015-01-22 0:28 ` Laurent Pinchart
@ 2015-01-26 6:38 ` Vinod Koul
2015-01-26 6:52 ` Kuninori Morimoto
4 siblings, 0 replies; 6+ messages in thread
From: Vinod Koul @ 2015-01-26 6:38 UTC (permalink / raw)
To: linux-sh
On Wed, Jan 21, 2015 at 04:42:22AM +0000, Kuninori Morimoto wrote:
> From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
>
> The driver doesn't support residue reporting at all.
> residue_granularity should be set to DMA_RESIDUE_GRANULARITY_DESCRIPTOR.
> Special thanks to Laurent
Applied, thanks
--
~Vinod
^ permalink raw reply [flat|nested] 6+ messages in thread* [PATCH] dmaengine: rcar-hpbdma: tidyup residue_granularity
2015-01-21 4:42 [PATCH] dmaengine: rcar-hpbdma: tidyup residue_granularity Kuninori Morimoto
` (3 preceding siblings ...)
2015-01-26 6:38 ` Vinod Koul
@ 2015-01-26 6:52 ` Kuninori Morimoto
4 siblings, 0 replies; 6+ messages in thread
From: Kuninori Morimoto @ 2015-01-26 6:52 UTC (permalink / raw)
To: linux-sh
From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
The driver doesn't support residue reporting at all.
residue_granularity should be set to DMA_RESIDUE_GRANULARITY_DESCRIPTOR.
Special thanks to Laurent
Reported-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
---
drivers/dma/sh/rcar-hpbdma.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/dma/sh/rcar-hpbdma.c b/drivers/dma/sh/rcar-hpbdma.c
index 6fef1b9..749f26e 100644
--- a/drivers/dma/sh/rcar-hpbdma.c
+++ b/drivers/dma/sh/rcar-hpbdma.c
@@ -600,7 +600,7 @@ static int hpb_dmae_probe(struct platform_device *pdev)
dma_dev->src_addr_widths = widths;
dma_dev->dst_addr_widths = widths;
dma_dev->directions = BIT(DMA_MEM_TO_DEV) | BIT(DMA_DEV_TO_MEM);
- dma_dev->residue_granularity = DMA_RESIDUE_GRANULARITY_BURST;
+ dma_dev->residue_granularity = DMA_RESIDUE_GRANULARITY_DESCRIPTOR;
hpbdev->shdma_dev.ops = &hpb_dmae_ops;
hpbdev->shdma_dev.desc_size = sizeof(struct hpb_desc);
--
1.7.9.5
--
To unsubscribe from this list: send the line "unsubscribe linux-sh" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply related [flat|nested] 6+ messages in thread