From: Simon Horman <horms@verge.net.au>
To: linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] ARM: shmobile: Select CONFIG_REGULATOR in defconfig once again
Date: Mon, 26 Jan 2015 08:47:49 +0000 [thread overview]
Message-ID: <20150126084743.GA24011@verge.net.au> (raw)
In-Reply-To: <87386yb2vl.wl%kuninori.morimoto.gx@renesas.com>
On Mon, Jan 26, 2015 at 04:07:18AM +0000, Kuninori Morimoto wrote:
>
> Hi Simon
>
> > > > eb4513482d1c4882e3633528ccc48d77581b7bb1
> > > > (ARM: shmobile: Enable kzm9g board in multiplatform defconfig)
> > > > dropped CONFIG_REGULATOR from shmobile_defconfig as it was
> > > > generated using a tree where CONFIG_REGULATOR is indirectly
> > > > selected by ARCH_SH73A0.
> > > >
> > > > ARCH_SH73A0 is not queued up for v3.20 and thus, baring unforeseen
> > > > changes, CONFIG_REGULATOR will not be selected by shmobile_defconfig
> > > > in that release. This causes at least SDHI to stop working on
> > > > R-Car Gen2 SoCs.
> > > >
> > > > Reported-by: Magnus Damm <damm+renesas@opensource.se>
> > > > Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
> > > > [horms: minimal patch targeted as a fix]
> > > > Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
> > > > ---
> > > > arch/arm/configs/shmobile_defconfig | 1 +
> > > > 1 file changed, 1 insertion(+)
> >
> > For the record, this patch is based on
> > renesas-next-20150122-v3.19-rc1.
>
> Thank you
>
> > > > diff --git a/arch/arm/configs/shmobile_defconfig b/arch/arm/configs/shmobile_defconfig
> > > > index 4f9868d..b553e2c 100644
> > > > --- a/arch/arm/configs/shmobile_defconfig
> > > > +++ b/arch/arm/configs/shmobile_defconfig
> > > > @@ -118,6 +118,7 @@ CONFIG_WATCHDOG=y
> > > > CONFIG_DA9063_WATCHDOG=y
> > > > CONFIG_MFD_AS3711=y
> > > > CONFIG_MFD_DA9063=y
> > > > +CONFIG_REGULATOR=y
> > > > CONFIG_REGULATOR_AS3711=y
> > > > CONFIG_REGULATOR_DA9210=y
> > > > CONFIG_REGULATOR_GPIO=y
> > >
> > > Oh.. Thank you for your help
> > > (I have sent other question mail)
> > > It looks good :)
> >
> > Thanks. I have tried to address your questions in an answer to your
> > other email. Can you confirm me know if the above patch is ok for you or not.
> > I'd like to get this one right :)
>
> It OK in my quick check
> Thank you
Thanks, I have queued this up as a fix for v3.20
and pushed it as part of renesas-next-20150126-v3.19-rc1.
next prev parent reply other threads:[~2015-01-26 8:47 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-26 2:26 [PATCH] ARM: shmobile: Select CONFIG_REGULATOR in defconfig once again Simon Horman
2015-01-26 2:31 ` Kuninori Morimoto
2015-01-26 3:59 ` Simon Horman
2015-01-26 4:07 ` Kuninori Morimoto
2015-01-26 8:47 ` Simon Horman [this message]
-- strict thread matches above, loose matches on Subject: below --
2015-01-29 1:31 [GIT PULL] Renesas ARM Based SoC Defconfig Fixes for v3.20 Simon Horman
2015-01-29 1:31 ` [PATCH] ARM: shmobile: Select CONFIG_REGULATOR in defconfig once again Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150126084743.GA24011@verge.net.au \
--to=horms@verge.net.au \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).