From: Simon Horman <horms@verge.net.au>
To: linux-sh@vger.kernel.org
Subject: Re: [PATCH v2] ARM: shmobile: r8a73a4: Instantiate GIC from C board code in legacy builds
Date: Thu, 29 Jan 2015 00:33:52 +0000 [thread overview]
Message-ID: <20150129003351.GD18731@verge.net.au> (raw)
In-Reply-To: <20150128124645.21199.99590.sendpatchset@little-apple>
On Wed, Jan 28, 2015 at 10:49:19PM +0900, Magnus Damm wrote:
> Hi Geert,
>
> On Wed, Jan 28, 2015 at 10:34 PM, Geert Uytterhoeven
> <geert@linux-m68k.org> wrote:
> > Hi Magnus,
> >
> > On Wed, Jan 28, 2015 at 1:46 PM, Magnus Damm <magnus.damm@gmail.com> wrote:
> >> From: Magnus Damm <damm+renesas@opensource.se>
> >>
> >> As of commit 9a1091ef0017c40a ("irqchip: gic: Support hierarchy irq
> >> domain."), the APE6EVM legacy board support is known to be broken.
> >>
> >> The IRQ numbers of the GIC are now virtual, and no longer match the
> >> hardcoded hardware IRQ numbers in the legacy platform board code.
> >>
> >> To fix this issue specific to non-muliplatform r8a73a4 and APE6EVM:
> >> 1) Instantiate the GIC from platform board code and also
> >> 2) Skip over the DT arch timer as well as
> >> 3) Force delay setup based on DT CPU frequency
> >>
> >> With these 3 fixes in place interrupts on APE6EVM are now unbroken.
> >>
> >> Partially based on legacy GIC fix by Geert Uytterhoeven, thanks to
> >> him for the initial work.
> >>
> >> Signed-off-by: Magnus Damm <damm+renesas@opensource.se>
> >
> > Thanks!
> >
> > Acked-by: Geert Uytterhoeven <geert+renesas@glider.be>
>
> Thank you!
>
> > BTW, has anything tested lager-legacy with v3.19-rcX?
> > We forgot about it as its removal is queued, but it's probably affected, too
> > (.init_irq is not set, and board-lager.c uses irq numbers in platform devices).
>
> Good point. I'm afraid I have not tested that one. I thought they were
> gone since long!
>
> To be honest, it seems kind of low priority since we should have
> working multiplatform support for that board anyway. Compared to
> r8a73a4 and APE6EVM where no multiplatform is available Lager and
> Koelsch must be in much better state.
FWIW I have tested lager with its defconfig on v3.19-rc6 and it seems broken.
I tend to agree with your analysis about the priority.
But I also tend to think that if its trivial to fix then it would
be worth doing so.
next prev parent reply other threads:[~2015-01-29 0:33 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-28 12:46 [PATCH v2] ARM: shmobile: r8a73a4: Instantiate GIC from C board code in legacy builds Magnus Damm
2015-01-28 13:34 ` Geert Uytterhoeven
2015-01-28 13:49 ` Magnus Damm
2015-01-29 0:33 ` Simon Horman [this message]
2015-01-29 0:35 ` Simon Horman
2015-01-29 0:49 ` Simon Horman
2015-01-29 6:42 ` Simon Horman
2015-01-30 0:43 ` Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150129003351.GD18731@verge.net.au \
--to=horms@verge.net.au \
--cc=linux-sh@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).