* Re: [RFC 2/5] ARM: shmobile: r8a7790: add node for rwdt
2015-02-01 14:47 [RFC 2/5] ARM: shmobile: r8a7790: add node for rwdt Wolfram Sang
@ 2015-02-02 9:05 ` Geert Uytterhoeven
2015-02-02 9:15 ` Wolfram Sang
` (4 subsequent siblings)
5 siblings, 0 replies; 7+ messages in thread
From: Geert Uytterhoeven @ 2015-02-02 9:05 UTC (permalink / raw)
To: linux-sh
On Sun, Feb 1, 2015 at 3:47 PM, Wolfram Sang <wsa@the-dreams.de> wrote:
> --- a/arch/arm/boot/dts/r8a7790.dtsi
> +++ b/arch/arm/boot/dts/r8a7790.dtsi
> @@ -123,6 +123,13 @@
> interrupts = <1 9 (GIC_CPU_MASK_SIMPLE(4) | IRQ_TYPE_LEVEL_HIGH)>;
> };
>
> + wdt0: wdt@e6020000 {
> + compatible = "renesas,rwdt-r8a7790", "renesas,rwdt-rcar";
> + reg = <0 0xe6020000 0 0x0c>;
The RWDT hardware block also has an interrupt:
interrupts = <GIC_SPI 140 IRQ_TYPE_LEVEL_HIGH>;
> + clocks = <&mstp4_clks R8A7790_CLK_RWDT>;
> + status = "disabled";
> + };
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [RFC 2/5] ARM: shmobile: r8a7790: add node for rwdt
2015-02-01 14:47 [RFC 2/5] ARM: shmobile: r8a7790: add node for rwdt Wolfram Sang
2015-02-02 9:05 ` Geert Uytterhoeven
@ 2015-02-02 9:15 ` Wolfram Sang
2015-02-02 9:34 ` Geert Uytterhoeven
` (3 subsequent siblings)
5 siblings, 0 replies; 7+ messages in thread
From: Wolfram Sang @ 2015-02-02 9:15 UTC (permalink / raw)
To: linux-sh
[-- Attachment #1: Type: text/plain, Size: 732 bytes --]
On Mon, Feb 02, 2015 at 10:05:37AM +0100, Geert Uytterhoeven wrote:
> On Sun, Feb 1, 2015 at 3:47 PM, Wolfram Sang <wsa@the-dreams.de> wrote:
> > --- a/arch/arm/boot/dts/r8a7790.dtsi
> > +++ b/arch/arm/boot/dts/r8a7790.dtsi
> > @@ -123,6 +123,13 @@
> > interrupts = <1 9 (GIC_CPU_MASK_SIMPLE(4) | IRQ_TYPE_LEVEL_HIGH)>;
> > };
> >
> > + wdt0: wdt@e6020000 {
> > + compatible = "renesas,rwdt-r8a7790", "renesas,rwdt-rcar";
> > + reg = <0 0xe6020000 0 0x0c>;
>
> The RWDT hardware block also has an interrupt:
>
> interrupts = <GIC_SPI 140 IRQ_TYPE_LEVEL_HIGH>;
Well, it is not used in the driver. I'd suggest to skip until it is
really needed.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [RFC 2/5] ARM: shmobile: r8a7790: add node for rwdt
2015-02-01 14:47 [RFC 2/5] ARM: shmobile: r8a7790: add node for rwdt Wolfram Sang
2015-02-02 9:05 ` Geert Uytterhoeven
2015-02-02 9:15 ` Wolfram Sang
@ 2015-02-02 9:34 ` Geert Uytterhoeven
2015-02-02 9:37 ` Wolfram Sang
` (2 subsequent siblings)
5 siblings, 0 replies; 7+ messages in thread
From: Geert Uytterhoeven @ 2015-02-02 9:34 UTC (permalink / raw)
To: linux-sh
Hi Wolfram,
On Mon, Feb 2, 2015 at 10:15 AM, Wolfram Sang <wsa@the-dreams.de> wrote:
> On Mon, Feb 02, 2015 at 10:05:37AM +0100, Geert Uytterhoeven wrote:
>> On Sun, Feb 1, 2015 at 3:47 PM, Wolfram Sang <wsa@the-dreams.de> wrote:
>> > --- a/arch/arm/boot/dts/r8a7790.dtsi
>> > +++ b/arch/arm/boot/dts/r8a7790.dtsi
>> > @@ -123,6 +123,13 @@
>> > interrupts = <1 9 (GIC_CPU_MASK_SIMPLE(4) | IRQ_TYPE_LEVEL_HIGH)>;
>> > };
>> >
>> > + wdt0: wdt@e6020000 {
>> > + compatible = "renesas,rwdt-r8a7790", "renesas,rwdt-rcar";
>> > + reg = <0 0xe6020000 0 0x0c>;
>>
>> The RWDT hardware block also has an interrupt:
>>
>> interrupts = <GIC_SPI 140 IRQ_TYPE_LEVEL_HIGH>;
>
> Well, it is not used in the driver. I'd suggest to skip until it is
> really needed.
That doesn't matter. DT should describe the hardware.... perfectly (stable DT
ABI etc.). And as it's a standard property, we don't have to think hard and
invent a good way to describe the presence of the interrupt.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [RFC 2/5] ARM: shmobile: r8a7790: add node for rwdt
2015-02-01 14:47 [RFC 2/5] ARM: shmobile: r8a7790: add node for rwdt Wolfram Sang
` (2 preceding siblings ...)
2015-02-02 9:34 ` Geert Uytterhoeven
@ 2015-02-02 9:37 ` Wolfram Sang
2015-02-02 11:06 ` Sergei Shtylyov
2015-02-02 11:09 ` Wolfram Sang
5 siblings, 0 replies; 7+ messages in thread
From: Wolfram Sang @ 2015-02-02 9:37 UTC (permalink / raw)
To: linux-sh
[-- Attachment #1: Type: text/plain, Size: 1196 bytes --]
On Mon, Feb 02, 2015 at 10:34:52AM +0100, Geert Uytterhoeven wrote:
> Hi Wolfram,
>
> On Mon, Feb 2, 2015 at 10:15 AM, Wolfram Sang <wsa@the-dreams.de> wrote:
> > On Mon, Feb 02, 2015 at 10:05:37AM +0100, Geert Uytterhoeven wrote:
> >> On Sun, Feb 1, 2015 at 3:47 PM, Wolfram Sang <wsa@the-dreams.de> wrote:
> >> > --- a/arch/arm/boot/dts/r8a7790.dtsi
> >> > +++ b/arch/arm/boot/dts/r8a7790.dtsi
> >> > @@ -123,6 +123,13 @@
> >> > interrupts = <1 9 (GIC_CPU_MASK_SIMPLE(4) | IRQ_TYPE_LEVEL_HIGH)>;
> >> > };
> >> >
> >> > + wdt0: wdt@e6020000 {
> >> > + compatible = "renesas,rwdt-r8a7790", "renesas,rwdt-rcar";
> >> > + reg = <0 0xe6020000 0 0x0c>;
> >>
> >> The RWDT hardware block also has an interrupt:
> >>
> >> interrupts = <GIC_SPI 140 IRQ_TYPE_LEVEL_HIGH>;
> >
> > Well, it is not used in the driver. I'd suggest to skip until it is
> > really needed.
>
> That doesn't matter. DT should describe the hardware.... perfectly (stable DT
> ABI etc.). And as it's a standard property, we don't have to think hard and
> invent a good way to describe the presence of the interrupt.
OK, will add.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [RFC 2/5] ARM: shmobile: r8a7790: add node for rwdt
2015-02-01 14:47 [RFC 2/5] ARM: shmobile: r8a7790: add node for rwdt Wolfram Sang
` (3 preceding siblings ...)
2015-02-02 9:37 ` Wolfram Sang
@ 2015-02-02 11:06 ` Sergei Shtylyov
2015-02-02 11:09 ` Wolfram Sang
5 siblings, 0 replies; 7+ messages in thread
From: Sergei Shtylyov @ 2015-02-02 11:06 UTC (permalink / raw)
To: linux-sh
Hello.
On 2/1/2015 5:47 PM, Wolfram Sang wrote:
> From: Wolfram Sang <wsa+renesas@sang-engineering.com>
> Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
> ---
> arch/arm/boot/dts/r8a7790.dtsi | 7 +++++++
> 1 file changed, 7 insertions(+)
> diff --git a/arch/arm/boot/dts/r8a7790.dtsi b/arch/arm/boot/dts/r8a7790.dtsi
> index 999d437496de..1fea7cb6dcd8 100644
> --- a/arch/arm/boot/dts/r8a7790.dtsi
> +++ b/arch/arm/boot/dts/r8a7790.dtsi
> @@ -123,6 +123,13 @@
> interrupts = <1 9 (GIC_CPU_MASK_SIMPLE(4) | IRQ_TYPE_LEVEL_HIGH)>;
> };
>
> + wdt0: wdt@e6020000 {
ePAPR section 2.2.2 says to name it "watchdog@e6020000".
WBR, Sergei
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [RFC 2/5] ARM: shmobile: r8a7790: add node for rwdt
2015-02-01 14:47 [RFC 2/5] ARM: shmobile: r8a7790: add node for rwdt Wolfram Sang
` (4 preceding siblings ...)
2015-02-02 11:06 ` Sergei Shtylyov
@ 2015-02-02 11:09 ` Wolfram Sang
5 siblings, 0 replies; 7+ messages in thread
From: Wolfram Sang @ 2015-02-02 11:09 UTC (permalink / raw)
To: linux-sh
[-- Attachment #1: Type: text/plain, Size: 107 bytes --]
> >+ wdt0: wdt@e6020000 {
>
> ePAPR section 2.2.2 says to name it "watchdog@e6020000".
Thanks!
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
^ permalink raw reply [flat|nested] 7+ messages in thread