Re: [RFC 4/5] ARM: shmobile: r8a7790: let rst module allow watchdog resets if desired

[Wolfram Sang <wsa@the-dreams.de>]

[-- Attachment #1: Type: text/plain, Size: 982 bytes --]


> > +void __init rcar_gen2_wdt_rst_init(void)
> > +{
> > +#if defined(CONFIG_WATCHDOG)
> > +       void __iomem *p = ioremap_nocache(WDTRSTCR, 4);
> > +       BUG_ON(!p);
> > +       iowrite32(0xa55a0000, p);
> 
> This is dangerous. If the xWDT was left running, the system will be
> restarted soon.

Agreed, that might be the case.

> I think clearing the xWDT reset mask should be handled in the WDT driver
> itself, when enabling the watchdog.

Yes, and masked again if WDT is disabled.

> It's slightly more complicated there, as we already have a driver for the
> SYSC on R-Mobile (rmobile-reset), and a device node can't be bound
> by both the syscon and the rmobile-reset driver.

Is it just complicated or is it an open issue how to handle that?

> Do you have a better idea?

Nope. I also thought that something like syscon must be used if the
initialization in arch-code won't work. Still, I tried first with the
least intrusive version :)


[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]