From mboxrd@z Thu Jan 1 00:00:00 1970 From: Simon Horman Date: Thu, 05 Mar 2015 00:34:33 +0000 Subject: Re: [PATCH 0/2] ARM: shmobile: ape6evm: Fix GPIO keys and wake-up Message-Id: <20150305003432.GA3011@verge.net.au> List-Id: References: <1425059319-13403-1-git-send-email-geert+renesas@glider.be> In-Reply-To: <1425059319-13403-1-git-send-email-geert+renesas@glider.be> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Geert Uytterhoeven Cc: Magnus Damm , Laurent Pinchart , Ulrich Hecht , linux-sh@vger.kernel.org, linux-gpio@vger.kernel.org, devicetree@vger.kernel.org On Fri, Feb 27, 2015 at 06:48:37PM +0100, Geert Uytterhoeven wrote: > Hi Simon, Magnus, > > This patch series adds the missing pull-up bias configuration for the > switches on the r8a73a4/ape6evm development board, and configures the > custom switch as a wake-up source. > > After this, the keys actually work, and the system can be resumed from > s2ram by pressing the custom switch. > > This depends functionally on "[PATCH 1/4] pinctrl: sh-pfc: Do not > overwrite bias configuration" in the series "[PATCH 0/4] pinctrl: > sh-pfc: Fix pin bias and cleanups" which I've just sent. But as this is > DTS, it can be applied independently. > > Thanks for your comments! Hi Geert, this seems fine to me. But I am reluctant to queue it up before the PFC changes are accepted, lest there be some change in direction. Please repost once the PFC changes have been accepted.