From mboxrd@z Thu Jan 1 00:00:00 1970 From: Simon Horman Date: Thu, 30 Apr 2015 04:56:40 +0000 Subject: Re: [PATCH] ARM: shmobile: koelsch: Fix adv7511 IRQ sensing Message-Id: <20150430045639.GG15511@verge.net.au> List-Id: References: <1430315743-8521-1-git-send-email-laurent.pinchart+renesas@ideasonboard.com> In-Reply-To: <1430315743-8521-1-git-send-email-laurent.pinchart+renesas@ideasonboard.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: linux-sh@vger.kernel.org Hi Laurent, On Wed, Apr 29, 2015 at 04:55:43PM +0300, Laurent Pinchart wrote: > The adv7511 IRQ is low level triggered, not falling edge triggered. The > wrong sense configuration results in no interrupt being triggered at > all, breaking hotplug detection. Fix it. Would I be correct in adding the following and queuing it up as a fix for v4.1 and v4.0-stable? Fixes: 83a0731b39f3 ("ARM: shmobile: koelsch: Add DU HDMI output support") > Signed-off-by: Laurent Pinchart > --- > arch/arm/boot/dts/r8a7791-koelsch.dts | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm/boot/dts/r8a7791-koelsch.dts b/arch/arm/boot/dts/r8a7791-koelsch.dts > index 74c3212f1f11..824ddab9c3ad 100644 > --- a/arch/arm/boot/dts/r8a7791-koelsch.dts > +++ b/arch/arm/boot/dts/r8a7791-koelsch.dts > @@ -545,7 +545,7 @@ > compatible = "adi,adv7511w"; > reg = <0x39>; > interrupt-parent = <&gpio3>; > - interrupts = <29 IRQ_TYPE_EDGE_FALLING>; > + interrupts = <29 IRQ_TYPE_LEVEL_LOW>; > > adi,input-depth = <8>; > adi,input-colorspace = "rgb"; > -- > Regards, > > Laurent Pinchart > > -- > To unsubscribe from this list: send the line "unsubscribe linux-sh" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html >