From: Wolfram Sang <wsa@the-dreams.de>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Cc: linux-i2c@vger.kernel.org, linux-sh@vger.kernel.org,
Magnus Damm <magnus.damm@gmail.com>,
Simon Horman <horms@verge.net.au>,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
Geert Uytterhoeven <geert@linux-m68k.org>
Subject: Re: [PATCH 1/4] i2c: add FUNC flag for slave capabilities
Date: Sat, 16 May 2015 08:22:16 +0000 [thread overview]
Message-ID: <20150516082216.GA4014@schokonusskuchen.bad> (raw)
In-Reply-To: <20150515113744.GS28888@pengutronix.de>
[-- Attachment #1: Type: text/plain, Size: 746 bytes --]
On Fri, May 15, 2015 at 01:37:44PM +0200, Uwe Kleine-König wrote:
> Hello Wolfram,
>
> On Thu, May 14, 2015 at 02:40:02PM +0200, Wolfram Sang wrote:
> > From: Wolfram Sang <wsa+renesas@sang-engineering.com>
> >
> > So users can check in advance if there is slave support.
> I wonder if the core should check if .{,un}reg_slave is != NULL and
> automatically set this bit accordingly.
I thought about this, too, but decided against it. Maybe some driver
doesn't want to make its slave interface public because it is
specialized for one use-case only (thinking ECs here)? Also, doing it
would be a little inconsistent, since we could do the same for
I2C_FUNC_I2C when master_xfer is populated. So, let's start simple I'd
say.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2015-05-16 8:22 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-14 12:40 [PATCH 0/4] i2c: small updates to the slave framework Wolfram Sang
[not found] ` <1431607205-2316-1-git-send-email-wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org>
2015-05-14 12:40 ` [PATCH 1/4] i2c: add FUNC flag for slave capabilities Wolfram Sang
[not found] ` <1431607205-2316-2-git-send-email-wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org>
2015-05-15 11:37 ` Uwe Kleine-König
2015-05-16 8:22 ` Wolfram Sang [this message]
[not found] ` <20150516082216.GA4014-oo5tB6JMkjKRinMKxDlMNPwbnWRJjS81@public.gmane.org>
2015-05-16 9:27 ` Uwe Kleine-König
2015-05-16 10:09 ` Wolfram Sang
2015-05-14 12:40 ` [PATCH 2/4] i2c: rcar: report slave capabilities to users Wolfram Sang
2015-05-14 12:40 ` [PATCH 3/4] i2c: slave: docs: be more precise about the prerequsites Wolfram Sang
2015-05-14 12:40 ` [PATCH 4/4] i2c: slave: add error messages to slave core Wolfram Sang
2015-05-31 23:30 ` Wolfram Sang
2015-05-15 8:22 ` [PATCH 0/4] i2c: small updates to the slave framework Geert Uytterhoeven
2015-05-31 23:29 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150516082216.GA4014@schokonusskuchen.bad \
--to=wsa@the-dreams.de \
--cc=geert@linux-m68k.org \
--cc=horms@verge.net.au \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
--cc=magnus.damm@gmail.com \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox