From mboxrd@z Thu Jan 1 00:00:00 1970 From: Vinod Koul Date: Fri, 22 May 2015 12:40:05 +0000 Subject: Re: [PATCH 1/4 v2] dmaengine: rcar-dmac: fixup spinlock in rcar-dmac Message-Id: <20150522122805.GW3140@localhost> List-Id: References: <878ucitwyh.wl%kuninori.morimoto.gx@renesas.com> <877fs2twwm.wl%kuninori.morimoto.gx@renesas.com> In-Reply-To: <877fs2twwm.wl%kuninori.morimoto.gx@renesas.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Kuninori Morimoto Cc: Linux-ALSA , Geert Uytterhoeven , Simon , Linux-SH , Cao Minh Hiep , Magnus , Liam Girdwood , Mark Brown , Laurent , dmaengine@vger.kernel.org, sakato , Nguyen Viet Dung On Thu, May 21, 2015 at 03:48:38AM +0000, Kuninori Morimoto wrote: > From: Kuninori Morimoto > > Current rcar-dmac driver is using spin_lock_irq() / spin_unlock_irq() > in some functions. But, some other driver might call DMAEngine API > during interrupt disabled. In such case, rcar-dmac side spin_unlock_irq() > forcefully allows all interrupts. Therefore, other driver receives > unexpected interruption, and its exclusive access control will be broken. > This patch replaces spin_lock_irq() to spin_lock_irqsave(), > and spin_unlock_irq() to spin_unlock_irqrestore(). > > Reported-by: Cao Minh Hiep > Signed-off-by: Kuninori Morimoto > Tested-by: Keita Kobayashi Acked-by: Vinod Koul Mark, please apply this thru your tree Thanks -- ~Vinod