* [PATCH/RFC] mmc: tmio: Fix timeout value for command request
@ 2015-06-14 17:23 Yoshihiro Kaneko
2015-06-15 5:49 ` Leon Romanovsky
2015-06-15 16:34 ` Wolfram Sang
0 siblings, 2 replies; 5+ messages in thread
From: Yoshihiro Kaneko @ 2015-06-14 17:23 UTC (permalink / raw)
To: linux-mmc
Cc: Ian Molton, Ulf Hansson, Simon Horman, Magnus Damm,
Kuninori Morimoto, linux-sh
From: Takeshi Kihara <takeshi.kihara.df@renesas.com>
Fix the problem which timeout occurs at the time of command request with
several cards.
The timeout value was insufficient as a verification of several cards,
so it was changed 5 seconds from 2 seconds.
Signed-off-by: Takeshi Kihara <takeshi.kihara.df@renesas.com>
Signed-off-by: Yoshihiro Kaneko <ykaneko0929@gmail.com>
---
This patch is based on mmc-next branch of Ulf Hansson's mmc tree.
drivers/mmc/host/tmio_mmc_pio.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/mmc/host/tmio_mmc_pio.c b/drivers/mmc/host/tmio_mmc_pio.c
index e3dcf31..0f7c4ae 100644
--- a/drivers/mmc/host/tmio_mmc_pio.c
+++ b/drivers/mmc/host/tmio_mmc_pio.c
@@ -230,7 +230,7 @@ static void tmio_mmc_reset_work(struct work_struct *work)
*/
if (IS_ERR_OR_NULL(mrq)
|| time_is_after_jiffies(host->last_req_ts +
- msecs_to_jiffies(2000))) {
+ msecs_to_jiffies(5000))) {
spin_unlock_irqrestore(&host->lock, flags);
return;
}
@@ -818,7 +818,7 @@ static void tmio_mmc_request(struct mmc_host *mmc, struct mmc_request *mrq)
ret = tmio_mmc_start_command(host, mrq->cmd);
if (!ret) {
schedule_delayed_work(&host->delayed_reset_work,
- msecs_to_jiffies(2000));
+ msecs_to_jiffies(5000));
return;
}
--
1.9.1
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH/RFC] mmc: tmio: Fix timeout value for command request
2015-06-14 17:23 [PATCH/RFC] mmc: tmio: Fix timeout value for command request Yoshihiro Kaneko
@ 2015-06-15 5:49 ` Leon Romanovsky
2015-06-21 15:46 ` Yoshihiro Kaneko
2015-06-15 16:34 ` Wolfram Sang
1 sibling, 1 reply; 5+ messages in thread
From: Leon Romanovsky @ 2015-06-15 5:49 UTC (permalink / raw)
To: Yoshihiro Kaneko
Cc: linux-mmc, Ian Molton, Ulf Hansson, Simon Horman, Magnus Damm,
Kuninori Morimoto, linux-sh
On Sun, Jun 14, 2015 at 8:23 PM, Yoshihiro Kaneko <ykaneko0929@gmail.com> wrote:
> From: Takeshi Kihara <takeshi.kihara.df@renesas.com>
>
> Fix the problem which timeout occurs at the time of command request with
> several cards.
>
> The timeout value was insufficient as a verification of several cards,
> so it was changed 5 seconds from 2 seconds.
Hi Yoshihiro,
Can you please throw a light on which cards you were reuqested to
increase the timeout?
>
> Signed-off-by: Takeshi Kihara <takeshi.kihara.df@renesas.com>
> Signed-off-by: Yoshihiro Kaneko <ykaneko0929@gmail.com>
> ---
>
> This patch is based on mmc-next branch of Ulf Hansson's mmc tree.
>
> drivers/mmc/host/tmio_mmc_pio.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/mmc/host/tmio_mmc_pio.c b/drivers/mmc/host/tmio_mmc_pio.c
> index e3dcf31..0f7c4ae 100644
> --- a/drivers/mmc/host/tmio_mmc_pio.c
> +++ b/drivers/mmc/host/tmio_mmc_pio.c
> @@ -230,7 +230,7 @@ static void tmio_mmc_reset_work(struct work_struct *work)
> */
> if (IS_ERR_OR_NULL(mrq)
> || time_is_after_jiffies(host->last_req_ts +
> - msecs_to_jiffies(2000))) {
> + msecs_to_jiffies(5000))) {
> spin_unlock_irqrestore(&host->lock, flags);
> return;
> }
> @@ -818,7 +818,7 @@ static void tmio_mmc_request(struct mmc_host *mmc, struct mmc_request *mrq)
> ret = tmio_mmc_start_command(host, mrq->cmd);
> if (!ret) {
> schedule_delayed_work(&host->delayed_reset_work,
> - msecs_to_jiffies(2000));
> + msecs_to_jiffies(5000));
> return;
> }
>
> --
> 1.9.1
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
--
Leon Romanovsky | Independent Linux Consultant
www.leon.nu | leon@leon.nu
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH/RFC] mmc: tmio: Fix timeout value for command request
2015-06-15 5:49 ` Leon Romanovsky
@ 2015-06-21 15:46 ` Yoshihiro Kaneko
0 siblings, 0 replies; 5+ messages in thread
From: Yoshihiro Kaneko @ 2015-06-21 15:46 UTC (permalink / raw)
To: Leon Romanovsky
Cc: linux-mmc, Ian Molton, Ulf Hansson, Simon Horman, Magnus Damm,
Kuninori Morimoto, Linux-sh list
Hi Leon,
2015-06-15 14:49 GMT+09:00 Leon Romanovsky <leon@leon.nu>:
> On Sun, Jun 14, 2015 at 8:23 PM, Yoshihiro Kaneko <ykaneko0929@gmail.com> wrote:
>> From: Takeshi Kihara <takeshi.kihara.df@renesas.com>
>>
>> Fix the problem which timeout occurs at the time of command request with
>> several cards.
>>
>> The timeout value was insufficient as a verification of several cards,
>> so it was changed 5 seconds from 2 seconds.
> Hi Yoshihiro,
> Can you please throw a light on which cards you were reuqested to
> increase the timeout?
I am inquiring to the person concerned.
Thanks,
Kaneko
>
>>
>> Signed-off-by: Takeshi Kihara <takeshi.kihara.df@renesas.com>
>> Signed-off-by: Yoshihiro Kaneko <ykaneko0929@gmail.com>
>> ---
>>
>> This patch is based on mmc-next branch of Ulf Hansson's mmc tree.
>>
>> drivers/mmc/host/tmio_mmc_pio.c | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/mmc/host/tmio_mmc_pio.c b/drivers/mmc/host/tmio_mmc_pio.c
>> index e3dcf31..0f7c4ae 100644
>> --- a/drivers/mmc/host/tmio_mmc_pio.c
>> +++ b/drivers/mmc/host/tmio_mmc_pio.c
>> @@ -230,7 +230,7 @@ static void tmio_mmc_reset_work(struct work_struct *work)
>> */
>> if (IS_ERR_OR_NULL(mrq)
>> || time_is_after_jiffies(host->last_req_ts +
>> - msecs_to_jiffies(2000))) {
>> + msecs_to_jiffies(5000))) {
>> spin_unlock_irqrestore(&host->lock, flags);
>> return;
>> }
>> @@ -818,7 +818,7 @@ static void tmio_mmc_request(struct mmc_host *mmc, struct mmc_request *mrq)
>> ret = tmio_mmc_start_command(host, mrq->cmd);
>> if (!ret) {
>> schedule_delayed_work(&host->delayed_reset_work,
>> - msecs_to_jiffies(2000));
>> + msecs_to_jiffies(5000));
>> return;
>> }
>>
>> --
>> 1.9.1
>>
>> --
>> To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
>> the body of a message to majordomo@vger.kernel.org
>> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
>
>
> --
> Leon Romanovsky | Independent Linux Consultant
> www.leon.nu | leon@leon.nu
--
To unsubscribe from this list: send the line "unsubscribe linux-sh" in
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH/RFC] mmc: tmio: Fix timeout value for command request
2015-06-14 17:23 [PATCH/RFC] mmc: tmio: Fix timeout value for command request Yoshihiro Kaneko
2015-06-15 5:49 ` Leon Romanovsky
@ 2015-06-15 16:34 ` Wolfram Sang
2015-06-21 15:52 ` Yoshihiro Kaneko
1 sibling, 1 reply; 5+ messages in thread
From: Wolfram Sang @ 2015-06-15 16:34 UTC (permalink / raw)
To: Yoshihiro Kaneko
Cc: linux-mmc, Ian Molton, Ulf Hansson, Simon Horman, Magnus Damm,
Kuninori Morimoto, linux-sh
[-- Attachment #1: Type: text/plain, Size: 728 bytes --]
Hi,
> @@ -230,7 +230,7 @@ static void tmio_mmc_reset_work(struct work_struct *work)
> */
> if (IS_ERR_OR_NULL(mrq)
> || time_is_after_jiffies(host->last_req_ts +
> - msecs_to_jiffies(2000))) {
> + msecs_to_jiffies(5000))) {
> spin_unlock_irqrestore(&host->lock, flags);
> return;
> }
> @@ -818,7 +818,7 @@ static void tmio_mmc_request(struct mmc_host *mmc, struct mmc_request *mrq)
> ret = tmio_mmc_start_command(host, mrq->cmd);
> if (!ret) {
> schedule_delayed_work(&host->delayed_reset_work,
> - msecs_to_jiffies(2000));
> + msecs_to_jiffies(5000));
What about using a define here since the same kind of magic value is
used in two different places?
Kind regards,
Wolfram
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH/RFC] mmc: tmio: Fix timeout value for command request
2015-06-15 16:34 ` Wolfram Sang
@ 2015-06-21 15:52 ` Yoshihiro Kaneko
0 siblings, 0 replies; 5+ messages in thread
From: Yoshihiro Kaneko @ 2015-06-21 15:52 UTC (permalink / raw)
To: Wolfram Sang
Cc: linux-mmc, Ian Molton, Ulf Hansson, Simon Horman, Magnus Damm,
Kuninori Morimoto, Linux-sh list
Hi Wolfram,
2015-06-16 1:34 GMT+09:00 Wolfram Sang <wsa@the-dreams.de>:
> Hi,
>
>> @@ -230,7 +230,7 @@ static void tmio_mmc_reset_work(struct work_struct *work)
>> */
>> if (IS_ERR_OR_NULL(mrq)
>> || time_is_after_jiffies(host->last_req_ts +
>> - msecs_to_jiffies(2000))) {
>> + msecs_to_jiffies(5000))) {
>> spin_unlock_irqrestore(&host->lock, flags);
>> return;
>> }
>> @@ -818,7 +818,7 @@ static void tmio_mmc_request(struct mmc_host *mmc, struct mmc_request *mrq)
>> ret = tmio_mmc_start_command(host, mrq->cmd);
>> if (!ret) {
>> schedule_delayed_work(&host->delayed_reset_work,
>> - msecs_to_jiffies(2000));
>> + msecs_to_jiffies(5000));
>
> What about using a define here since the same kind of magic value is
> used in two different places?
Sounds good. I will do it in the next version.
Thanks,
Kaneko
>
> Kind regards,
>
> Wolfram
>
--
To unsubscribe from this list: send the line "unsubscribe linux-sh" in
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2015-06-21 15:52 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-06-14 17:23 [PATCH/RFC] mmc: tmio: Fix timeout value for command request Yoshihiro Kaneko
2015-06-15 5:49 ` Leon Romanovsky
2015-06-21 15:46 ` Yoshihiro Kaneko
2015-06-15 16:34 ` Wolfram Sang
2015-06-21 15:52 ` Yoshihiro Kaneko
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).