Re: [PATCH] i2c-tools: enable static use of libi2c

[Wolfram Sang <wsa@the-dreams.de>]

[-- Attachment #1: Type: text/plain, Size: 831 bytes --]

Hi Jean,

> > When debugging embedded systems, it is often nice to simply TFTP the
> > desired i2ctool to the target without the hazzle of dealing with shared
> > libs. Using -static is overkill, too, so let's add a switch which will
> > only link functions from libi2c statically.
> 
> Fine with me.

Hooray!

> >  BUILD_STATIC_LIB ?= 1
> > +# Uncomment to use static libi2c
> > +#USE_STATIC_LIB := 1
> 
> Any reason for not using ?= as above, with the default being unset?

Agreed.

> Unrelated to your patch, but shouldn't this -Llib rather been written
> -L$(LIB_DIR)?

Yes, makes sense.

> Also it might make sense to check if USE_STATIC_LIB is set when
> BUILD_STATIC_LIB isn't and complain about it?

For easier usage, I'd rather enforce BUILD_STATIC_LIB in that case.

Thanks,

   Wolfram


[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]