From: Steven Rostedt <rostedt@goodmis.org>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Rob Landley <rob@landley.net>, Jiri Slaby <jslaby@suse.cz>,
Andrew Morton <akpm@linux-foundation.org>,
Geert Uytterhoeven <geert+renesas@glider.be>,
Kevin Hilman <khilman@linaro.org>,
"Rafael J. Wysocki" <rafael.j.wysocki@intel.com>,
Vivek Goyal <vgoyal@redhat.com>,
"Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>,
Riku Voipio <riku.voipio@linaro.org>,
Jiri Kosina <jkosina@suse.cz>, Paul Bolle <pebolle@tiscali.nl>,
Ingo Molnar <mingo@kernel.org>,
Peter Zijlstra <peterz@infradead.org>,
Davidlohr Bueso <davidlohr@hp.com>,
Richard Weinberger <richard@nod.at>, Zhigang Lu <zlu@tilera.com>,
Vineet Gupta <vgupta@synopsys.com>,
Richard Kuo <rkuo@codeaurora.org>,
Max Filippov <jcmvbkbc@gmail.com>,
Pranith Kumar <bobby.prani@gmail.com>,
linux-sh@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-serial@vger.kernel.org, ysato@users.sourceforge.jp
Subject: Re: [PATCH 2/2] Changes to existing files for 0PF FPGA board.
Date: Thu, 18 Jun 2015 19:02:13 +0000 [thread overview]
Message-ID: <20150618150213.6fd30752@gandalf.local.home> (raw)
In-Reply-To: <20150618175931.GA11748@kroah.com>
On Thu, 18 Jun 2015 10:59:31 -0700
Greg Kroah-Hartman <gregkh@linuxfoundation.org> wrote:
> On Thu, Jun 18, 2015 at 10:19:19AM -0700, Rob Landley wrote:
> > Changes to existing files to add 0pf j2 board support.
> >
>
> That's the second worse commit message and subject: line I've read
> today.
Only the second worse today? Damn, you must get a lot of crappy change
logs.
>
> And there's no signed off by line.
>
> And there was no 1/2 patch sent.
>
> And, most importantly:
>
> > diff --git a/arch/sh/Kconfig b/arch/sh/Kconfig
>
> I don't care about arch/sh/ stuff, why are you sending this to me?
Because even when you don't care, you still give back constructive
feedback ;-)
-- Steve
>
> You have a bit of work to do here...
>
> greg k-h
next prev parent reply other threads:[~2015-06-18 19:02 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-18 17:19 [PATCH 0/2] 0pf-j2 (sh2-compatible open hardware) FPGA board support Rob Landley
2015-06-18 17:19 ` [PATCH 1/2] New files for 0PF FPGA board Rob Landley
2015-06-19 7:47 ` Geert Uytterhoeven
2015-06-18 17:19 ` [PATCH 2/2] Changes to existing " Rob Landley
2015-06-18 17:59 ` Greg Kroah-Hartman
2015-06-18 19:02 ` Steven Rostedt [this message]
2015-06-19 21:57 ` Rob Landley
2015-06-19 22:49 ` Greg Kroah-Hartman
2015-06-18 19:36 ` Geert Uytterhoeven
2015-06-19 22:11 ` Rob Landley
2015-06-20 8:00 ` Geert Uytterhoeven
2015-06-20 20:13 ` Rob Landley
2015-06-20 20:48 ` Geert Uytterhoeven
2015-06-22 4:26 ` Yoshinori Sato
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150618150213.6fd30752@gandalf.local.home \
--to=rostedt@goodmis.org \
--cc=akpm@linux-foundation.org \
--cc=bobby.prani@gmail.com \
--cc=davidlohr@hp.com \
--cc=geert+renesas@glider.be \
--cc=gregkh@linuxfoundation.org \
--cc=jcmvbkbc@gmail.com \
--cc=jkosina@suse.cz \
--cc=jslaby@suse.cz \
--cc=khilman@linaro.org \
--cc=kirill.shutemov@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=pebolle@tiscali.nl \
--cc=peterz@infradead.org \
--cc=rafael.j.wysocki@intel.com \
--cc=richard@nod.at \
--cc=riku.voipio@linaro.org \
--cc=rkuo@codeaurora.org \
--cc=rob@landley.net \
--cc=vgoyal@redhat.com \
--cc=vgupta@synopsys.com \
--cc=ysato@users.sourceforge.jp \
--cc=zlu@tilera.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).