From: Simon Horman <horms@verge.net.au>
To: linux-sh@vger.kernel.org
Subject: Re: [PATCH] gpio: rcar: Add r8a7795 (R-Car H3) support
Date: Tue, 23 Jun 2015 23:39:34 +0000 [thread overview]
Message-ID: <20150623233932.GA9988@verge.net.au> (raw)
In-Reply-To: <1434710308-15901-1-git-send-email-ulrich.hecht+renesas@gmail.com>
On Mon, Jun 22, 2015 at 01:03:14AM +0000, Kuninori Morimoto wrote:
>
> Hi Ulrich
>
> > R-Car Gen3's GPIO blocks are identical to Gen2's in every respect.
> (snip)
> > diff --git a/drivers/gpio/gpio-rcar.c b/drivers/gpio/gpio-rcar.c
> > index fd39774..e962ad5 100644
> > --- a/drivers/gpio/gpio-rcar.c
> > +++ b/drivers/gpio/gpio-rcar.c
> > @@ -318,6 +318,9 @@ static const struct of_device_id gpio_rcar_of_table[] = {
> > .compatible = "renesas,gpio-r8a7794",
> > .data = &gpio_rcar_info_gen2,
> > }, {
> > + .compatible = "renesas,gpio-r8a7795",
> > + .data = &gpio_rcar_info_gen2,
> > + }, {
> > .compatible = "renesas,gpio-rcar",
> > .data = &gpio_rcar_info_gen1,
> > }, {
>
> I would like to have "gen3", or have comment /* gen3 compatible */
I don't feel strongly about this, however, unless I am mistaken the name
in question is internal to this driver. So from my point of view a comment
would suffice.
next prev parent reply other threads:[~2015-06-23 23:39 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-19 10:38 [PATCH] gpio: rcar: Add r8a7795 (R-Car H3) support Ulrich Hecht
2015-06-19 11:39 ` Khiem Nguyen
2015-06-22 1:03 ` Kuninori Morimoto
2015-06-23 23:39 ` Simon Horman [this message]
2015-07-13 10:07 ` Linus Walleij
2015-07-13 18:52 ` Laurent Pinchart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150623233932.GA9988@verge.net.au \
--to=horms@verge.net.au \
--cc=linux-sh@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).