Re: [PATCH v2] ARM: shmobile: r8a7779 Marzen legacy fix V2

[Simon Horman <horms@verge.net.au>]

Hi Geert,

On Wed, Jul 15, 2015 at 09:37:30AM +0200, Geert Uytterhoeven wrote:
> On Wed, Jul 15, 2015 at 8:53 AM, Simon Horman <horms@verge.net.au> wrote:
> > On Wed, Jul 15, 2015 at 03:49:01PM +0900, Magnus Damm wrote:
> >> On Wed, Jul 15, 2015 at 3:47 PM, Simon Horman <horms@verge.net.au> wrote:
> >> > On Wed, Jul 15, 2015 at 02:59:32PM +0900, Magnus Damm wrote:
> >> >> Hi Simon,
> >> >>
> >> >> On Wed, Jul 15, 2015 at 9:23 AM, Simon Horman <horms@verge.net.au> wrote:
> >> >> > On Tue, Jul 14, 2015 at 04:25:22PM +0900, Magnus Damm wrote:
> >> >> >> From: Magnus Damm <damm+renesas@opensource.se>
> >> >> >>
> >> >> >> Unbreak the r8a7779 Marzen legacy code provided by marzen_defconfig.
> >> >> >>
> >> >> >> As it is today Marzen multiplatform is working, but the legacy code
> >> >> >> is broken. This patch intends to leave multiplatform as-is but do
> >> >> >> a simple one-shot fix to unbreak the legacy code base.
> >> >> >>
> >> >> >> Without this patch there is no preset delay and the TWD is defined
> >> >> >> both in C code and in DT. Solve the delay by invoking shmobile_init_delay()
> >> >> >> and simply disable TWD in case of building for legacy.
> >> >> >>
> >> >> >> Marzen legacy code will be removed in the near future, but until then
> >> >> >> we may as well avoid breaking it.
> >> >> >>
> >> >> >> Signed-off-by: Magnus Damm <damm+renesas@opensource.se>
> 
> > With the above in mind I will queue this up with the Fixes tag
> > as a fix for v4.3. It may well filter into -stable from there.
> 
> Before you tag it for stable: keeping in mind commit 30225743852ed5c3
> ("ARM: shmobile: sh73a0 dtsi: Add Cortex-A9 TWD node), does it work with
> CONFIG_CPU_IDLE=y?

CONFIG_CPU_IDLE=y
CONFIG_CPU_IDLE_GOV_LADDER=y
CONFIG_CPU_IDLE_GOV_MENU=y
CONFIG_DT_IDLE_STATES=y
CONFIG_ARM_CPUIDLE=y

I tried enabling the above and then tested booting the marzen
board both with and without this patch (the one in the subject of the email).

The result was the same as without the above options enabled:

* The patch seems to be required for marzen to boot to any
  kind of console without CONFIG_DEBUG_LL set.