From: Russell King - ARM Linux <linux@arm.linux.org.uk>
To: linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 2/2] ARM: xip: Use correct symbol for end of ROM marker
Date: Thu, 16 Jul 2015 16:12:19 +0000 [thread overview]
Message-ID: <20150716161219.GL7557@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <1437057434-1616-3-git-send-email-chris.brandt@renesas.com>
On Thu, Jul 16, 2015 at 10:37:14AM -0400, Chris Brandt wrote:
> For an XIP build, _edata_loc, not _etext, is the end of constant R/O
> memory that needs to be mapped into the MODULES_VADDR area. This fixes
> the bug where you might loose part of your R/O data after page table
> setup is complete.
That's not correct. _etext is set in the linker script to be the end of
the text + readonly data + exception table + unwinder tables + notes.
_edata_loc is the end address of the read/write data section stored in
read-only memory, which exists to be copied by the early kernel assembly
code to RAM. There's no need for that to remain mapped.
I think you need to either provide more details of the problem you're
seeing, or further reasoning why this is a correct change.
--
FTTC broadband for 0.8mile line: currently at 10.5Mbps down 400kbps up
according to speedtest.net.
next prev parent reply other threads:[~2015-07-16 16:12 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-16 14:37 [PATCH 0/2] ARM: xip: Get XIP for ARMv7 working again Chris Brandt
2015-07-16 14:37 ` [PATCH 1/2] ARM: xip: Can't use text area as stack Chris Brandt
2015-07-16 14:37 ` [PATCH 2/2] ARM: xip: Use correct symbol for end of ROM marker Chris Brandt
2015-07-16 16:12 ` Russell King - ARM Linux [this message]
2015-07-16 16:23 ` Chris Brandt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150716161219.GL7557@n2100.arm.linux.org.uk \
--to=linux@arm.linux.org.uk \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox