SUPERH platform development
 help / color / mirror / Atom feed
From: Stephen Boyd <sboyd@codeaurora.org>
To: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Cc: Magnus Damm <magnus.damm@gmail.com>,
	linux-clk <linux-clk@vger.kernel.org>,
	Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>,
	Gaku Inami <gaku.inami.xw@bp.renesas.com>,
	Michael Turquette <mturquette@baylibre.com>,
	SH-Linux <linux-sh@vger.kernel.org>,
	"Simon Horman [Horms]" <horms@verge.net.au>,
	Geert Uytterhoeven <geert@linux-m68k.org>
Subject: Re: [PATCH][RFC] clk: Use node name and index for clock name
Date: Wed, 09 Sep 2015 21:39:10 +0000	[thread overview]
Message-ID: <20150909213910.GU15099@codeaurora.org> (raw)
In-Reply-To: <1981230.p8F5aT0ffl@avalon>

On 09/09, Laurent Pinchart wrote:
> On Wednesday 09 September 2015 14:27:58 Magnus Damm wrote:
> > On Wed, Sep 9, 2015 at 2:14 PM, Laurent Pinchart wrote:
> > > Another issue is that this won't guarantee that the names are unique as
> > > multiple DT nodes can have the same name. Instead of trying to generate
> > > unique names, would it be possible to handle clock registration and
> > > lookup without relying on names for DT-based platforms ?
> > 
> > It would of course make sense to do that for the long run, but at the
> > same time that sounds like major internal API rework since most
> > functions operate on string clock names today. So for short term is
> > the correct approach to use clock-output-names?
> 
> I think Stephen and Mike should comment on that.
> 

We've been murmuring about moving away from string based parent
child relationship descriptions for some time now. Nothing very
concrete has come out though and I haven't thought about it in
too much detail.

Why can't we call clk_get() for the clocks that we need to find
the name of, and then call __clk_get_name() on them? Doing
clk_get() has the nice side-effect of ordering probe for
different clock controller drivers so that things like
suspend/resume are done in the correct order.

-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project

  reply	other threads:[~2015-09-09 21:39 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-09-09  5:05 [PATCH][RFC] clk: Use node name and index for clock name Magnus Damm
2015-09-09  5:14 ` Laurent Pinchart
2015-09-09  5:27   ` Magnus Damm
2015-09-09  5:42     ` Laurent Pinchart
2015-09-09 21:39       ` Stephen Boyd [this message]
2015-09-14 12:06         ` Geert Uytterhoeven
2015-09-16  9:33         ` Magnus Damm
2015-09-09  9:21 ` Geert Uytterhoeven
2015-09-14 12:02   ` Geert Uytterhoeven
2015-09-15 11:36     ` Magnus Damm

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150909213910.GU15099@codeaurora.org \
    --to=sboyd@codeaurora.org \
    --cc=gaku.inami.xw@bp.renesas.com \
    --cc=geert@linux-m68k.org \
    --cc=horms@verge.net.au \
    --cc=kuninori.morimoto.gx@renesas.com \
    --cc=laurent.pinchart@ideasonboard.com \
    --cc=linux-clk@vger.kernel.org \
    --cc=linux-sh@vger.kernel.org \
    --cc=magnus.damm@gmail.com \
    --cc=mturquette@baylibre.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox