SUPERH platform development
 help / color / mirror / Atom feed
From: Wolfram Sang <wsa@the-dreams.de>
To: linux-sh@vger.kernel.org
Subject: Re: [PATCH 07/14][RFC] arm64: renesas: salvator-x: enable I2C
Date: Thu, 10 Sep 2015 12:13:58 +0000	[thread overview]
Message-ID: <20150910121358.GA1672@katana> (raw)
In-Reply-To: <87h9n2n3x1.wl%kuninori.morimoto.gx@renesas.com>

[-- Attachment #1: Type: text/plain, Size: 268 bytes --]


> +&i2c2 {
> +	pinctrl-0 = <&i2c2_pins>;
> +	pinctrl-names = "default";
> +
> +	status = "okay";
> +};

I think we should add the bus speed here explicitly and not rely on a
default:

	clock-frequency = <100000>;

Maybe 400000 if all connected devices support that.


[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

  parent reply	other threads:[~2015-09-10 12:13 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-09-10  7:16 [PATCH 07/14][RFC] arm64: renesas: salvator-x: enable I2C Kuninori Morimoto
2015-09-10  9:30 ` Geert Uytterhoeven
2015-09-10 12:13 ` Wolfram Sang [this message]
2015-09-11  0:27 ` Kuninori Morimoto

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150910121358.GA1672@katana \
    --to=wsa@the-dreams.de \
    --cc=linux-sh@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox