[PATCH 0/3] Basic GPIO support for r8a7795

[PATCH 0/3] Basic GPIO support for r8a7795

[Ulrich Hecht]

Hi!

This has been broken out of horms's GPIO and EthernetAVB RFC (thanks again)
and has its minor issues fixed, hopefully.  Specifically, it fixes the GPIO
6 and 7 clock references, dumps the MSTP's "clock-output-names" property,
and omits the extraneous options in defconfig.

CU
Uli


Changes since RFC:
- fix GPIO6 and GPIO7 clock assignments
- remove "clock-output-names" property from MSTP
- do not enable GPIO_SYSFS, LEDS_GPIO in defconfig


Takeshi Kihara (3):
  arm64: dts: r8a7795: add GPIO clocks
  arm64: dts: r8a7795: add GPIO nodes
  arm64: defconfig: Enable GPIO of Renesas R-Car Gen3 SoC

 arch/arm64/boot/dts/renesas/r8a7795.dtsi  | 128 ++++++++++++++++++++++++++++++
 arch/arm64/configs/defconfig              |   1 +
 include/dt-bindings/clock/r8a7795-clock.h |   8 ++
 3 files changed, 137 insertions(+)

-- 
2.4.6

Re: [PATCH 0/3] Basic GPIO support for r8a7795

[Simon Horman]

Hi Ulrich,

On Mon, Aug 31, 2015 at 05:36:38PM +0200, Ulrich Hecht wrote:
> Hi!
> 
> This has been broken out of horms's GPIO and EthernetAVB RFC (thanks again)
> and has its minor issues fixed, hopefully.  Specifically, it fixes the GPIO
> 6 and 7 clock references, dumps the MSTP's "clock-output-names" property,
> and omits the extraneous options in defconfig.

I have pushed this seris to the renesas tree in the topic/r8a7795-gpio-v1
branch.  It is based on the topic/arm64-rcar-gen3-v8 branch.

To be quite clear none of these patches are queued up for mainline yet and
as such they are not included in the next or devel branches of the renesas
tree.

Re: [PATCH 0/3] Basic GPIO support for r8a7795

[Simon Horman]

On Tue, Sep 01, 2015 at 10:22:04AM +0900, Simon Horman wrote:
> Hi Ulrich,
> 
> On Mon, Aug 31, 2015 at 05:36:38PM +0200, Ulrich Hecht wrote:
> > Hi!
> > 
> > This has been broken out of horms's GPIO and EthernetAVB RFC (thanks again)
> > and has its minor issues fixed, hopefully.  Specifically, it fixes the GPIO
> > 6 and 7 clock references, dumps the MSTP's "clock-output-names" property,
> > and omits the extraneous options in defconfig.
> 
> I have pushed this seris to the renesas tree in the topic/r8a7795-gpio-v1
> branch.  It is based on the topic/arm64-rcar-gen3-v8 branch.
> 
> To be quite clear none of these patches are queued up for mainline yet and
> as such they are not included in the next or devel branches of the renesas
> tree.

I added a new topic branch, topic/r8a7795-gpio-v1.rebase, which
is this series rebased on top of topic/arm64-rcar-gen3-v9.

As I was unsure if this is what you want I have kept the
topic/r8a7795-gpio-v1 branch unchanged.

Re: [PATCH 0/3] Basic GPIO support for r8a7795

[Simon Horman]

Hi Ulrich,

On Mon, Aug 31, 2015 at 05:36:38PM +0200, Ulrich Hecht wrote:
> Hi!
> 
> This has been broken out of horms's GPIO and EthernetAVB RFC (thanks again)
> and has its minor issues fixed, hopefully.  Specifically, it fixes the GPIO
> 6 and 7 clock references, dumps the MSTP's "clock-output-names" property,
> and omits the extraneous options in defconfig.

I have taken the liberty of:

* rebasing and updating this patch set on top of
  "[PATCH v10 00/07] Renesas R-Car H3 (r8a7795) integration patches V10"
* Updating the patch set to to once again have clock-output-names using the
  following update below provided to me by Geert - hopefully that
  merry-go-round has now paused for v4.4.
* Updating the clock definition order by folding in
  "arm64: dts: r8a7795: add GPIO clocks"

I would greatly appreciate if you and any other interested parties could
review the result which can be found in the topic/r8a7795-gpio-v1.rebase2
branch of the renesas tree.  If you find any problems please repost the
patch set at your earliest convenience.

diff --git a/arch/arm64/boot/dts/renesas/r8a7795.dtsi b/arch/arm64/boot/dts/renesas/r8a7795.dtsi
index f1c47ad3ea7fc781..8ce92db14c8bd101 100644
--- a/arch/arm64/boot/dts/renesas/r8a7795.dtsi
+++ b/arch/arm64/boot/dts/renesas/r8a7795.dtsi
@@ -530,6 +530,10 @@
 						R8A7795_CLK_I2C2  R8A7795_CLK_I2C1
 						R8A7795_CLK_I2C0
 					>;
+					clock-output-names +						"gpio7", "gpio6", "gpio5",
+						"gpio4", "gpio3", "gpio2",
+						"gpio1", "gpio0";
 				};
 
 				mstp10_clks: mstp10_clks@e6150998 {
-- 
1.9.1

Re: [PATCH 0/3] Basic GPIO support for r8a7795

[Ulrich Hecht]

On Mon, Oct 5, 2015 at 4:27 AM, Simon Horman <horms@verge.net.au> wrote:
> I have taken the liberty of:
>
> * rebasing and updating this patch set on top of
>   "[PATCH v10 00/07] Renesas R-Car H3 (r8a7795) integration patches V10"
> * Updating the patch set to to once again have clock-output-names using the
>   following update below provided to me by Geert - hopefully that
>   merry-go-round has now paused for v4.4.
> * Updating the clock definition order by folding in
>   "arm64: dts: r8a7795: add GPIO clocks"
>
> I would greatly appreciate if you and any other interested parties could
> review the result which can be found in the topic/r8a7795-gpio-v1.rebase2
> branch of the renesas tree.  If you find any problems please repost the
> patch set at your earliest convenience.

Thanks a lot, codewise that looks perfect to me.  I believe, however,
that in "arm64: dts: r8a7795: add GPIO clocks" there is a
"Signed-off-by: " missing before Morimoto-san's name.  Should I
add/repost that, or is it easier if you touched it up in your branch?

CU
Uli

Re: [PATCH 0/3] Basic GPIO support for r8a7795

[Simon Horman]

On Mon, Oct 05, 2015 at 11:20:15AM +0200, Ulrich Hecht wrote:
> On Mon, Oct 5, 2015 at 4:27 AM, Simon Horman <horms@verge.net.au> wrote:
> > I have taken the liberty of:
> >
> > * rebasing and updating this patch set on top of
> >   "[PATCH v10 00/07] Renesas R-Car H3 (r8a7795) integration patches V10"
> > * Updating the patch set to to once again have clock-output-names using the
> >   following update below provided to me by Geert - hopefully that
> >   merry-go-round has now paused for v4.4.
> > * Updating the clock definition order by folding in
> >   "arm64: dts: r8a7795: add GPIO clocks"
> >
> > I would greatly appreciate if you and any other interested parties could
> > review the result which can be found in the topic/r8a7795-gpio-v1.rebase2
> > branch of the renesas tree.  If you find any problems please repost the
> > patch set at your earliest convenience.
> 
> Thanks a lot, codewise that looks perfect to me.  I believe, however,
> that in "arm64: dts: r8a7795: add GPIO clocks" there is a
> "Signed-off-by: " missing before Morimoto-san's name.  Should I
> add/repost that, or is it easier if you touched it up in your branch?

Sorry about that Morimoto-san.

I suggest we fix that the next time either of us have to update
the patches as there are several topic branches sitting on top
of this one so I think its best to batch respinning them.

Re: [PATCH 0/3] Basic GPIO support for r8a7795

[Simon Horman]

On Tue, Oct 06, 2015 at 09:50:58AM +0900, Simon Horman wrote:
> On Mon, Oct 05, 2015 at 11:20:15AM +0200, Ulrich Hecht wrote:
> > On Mon, Oct 5, 2015 at 4:27 AM, Simon Horman <horms@verge.net.au> wrote:
> > > I have taken the liberty of:
> > >
> > > * rebasing and updating this patch set on top of
> > >   "[PATCH v10 00/07] Renesas R-Car H3 (r8a7795) integration patches V10"
> > > * Updating the patch set to to once again have clock-output-names using the
> > >   following update below provided to me by Geert - hopefully that
> > >   merry-go-round has now paused for v4.4.
> > > * Updating the clock definition order by folding in
> > >   "arm64: dts: r8a7795: add GPIO clocks"
> > >
> > > I would greatly appreciate if you and any other interested parties could
> > > review the result which can be found in the topic/r8a7795-gpio-v1.rebase2
> > > branch of the renesas tree.  If you find any problems please repost the
> > > patch set at your earliest convenience.
> > 
> > Thanks a lot, codewise that looks perfect to me.  I believe, however,
> > that in "arm64: dts: r8a7795: add GPIO clocks" there is a
> > "Signed-off-by: " missing before Morimoto-san's name.  Should I
> > add/repost that, or is it easier if you touched it up in your branch?
> 
> Sorry about that Morimoto-san.
> 
> I suggest we fix that the next time either of us have to update
> the patches as there are several topic branches sitting on top
> of this one so I think its best to batch respinning them.

I have now:

* Corrected the Signed-off-by: " problem
* Rebased this branch on top of
  "[PATCH v11 0/8] arm64: renesas: Add Renesas R8A7795 SoC support"
   a.k.a. topic/arm64-rcar-gen3-v11

The result is present in the topic/r8a7795-gpio-v1.rebase3 branch of
the renesas tree.

As always, please feel free to repost or otherwise point out any problems.