From: Ross Zwisler <ross.zwisler@linux.intel.com>
To: Ross Zwisler <ross.zwisler@linux.intel.com>
Cc: linux-kernel@vger.kernel.org, linux-sh@vger.kernel.org,
Geert Uytterhoeven <geert@linux-m68k.org>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Matthew Wilcox <willy@linux.intel.com>,
linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH] sh: add copy_user_page() alias for __copy_user()
Date: Thu, 08 Oct 2015 23:07:34 +0000 [thread overview]
Message-ID: <20151008230734.GB19399@linux.intel.com> (raw)
In-Reply-To: <1442958411-4271-1-git-send-email-ross.zwisler@linux.intel.com>
On Tue, Sep 22, 2015 at 03:46:51PM -0600, Ross Zwisler wrote:
> copy_user_page() is needed by DAX. Without this we get a compile error
> for DAX on SH:
>
> fs/dax.c:280:2: error: implicit declaration of function ‘copy_user_page’
> [-Werror=implicit-function-declaration]
> copy_user_page(vto, (void __force *)vfrom, vaddr, to);
> ^
>
> This was done with a random config that happened to include DAX support.
>
> This patch has only been compile tested.
>
> Signed-off-by: Ross Zwisler <ross.zwisler@linux.intel.com>
> Reported-by: Geert Uytterhoeven <geert@linux-m68k.org>
> ---
> Apologies for the resend, I wanted to add some more recipients.
> ---
> arch/sh/include/asm/page.h | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/sh/include/asm/page.h b/arch/sh/include/asm/page.h
> index fe20d14..ceb5201 100644
> --- a/arch/sh/include/asm/page.h
> +++ b/arch/sh/include/asm/page.h
> @@ -59,6 +59,7 @@ pages_do_alias(unsigned long addr1, unsigned long addr2)
>
> #define clear_page(page) memset((void *)(page), 0, PAGE_SIZE)
> extern void copy_page(void *to, void *from);
> +#define copy_user_page(to, from, vaddr, pg) __copy_user(to, from, PAGE_SIZE)
>
> struct page;
> struct vm_area_struct;
Ping?
next prev parent reply other threads:[~2015-10-08 23:07 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-22 21:44 [PATCH] sh: add copy_user_page() alias for __copy_user() Ross Zwisler
2015-09-22 21:46 ` Ross Zwisler
2015-10-08 23:07 ` Ross Zwisler [this message]
2015-10-12 8:56 ` Matt Fleming
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151008230734.GB19399@linux.intel.com \
--to=ross.zwisler@linux.intel.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=geert@linux-m68k.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
--cc=willy@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).