Re: [PATCH] ARM: shmobile: porter: add QSPI DT support

[Simon Horman <horms@verge.net.au>]

[Cc Geert]

On Fri, Oct 09, 2015 at 11:51:05PM +0300, Sergei Shtylyov wrote:
> Define the Porter board dependent part of the QSPI device node.
> Add device nodes  for Spansion  S25FL512S SPI flash and the MTD partitions
> on it.
> 
> This patch is  mostly analogous to the commit f59838d44835 (ARM: shmobile:
> henninger: add QSPI DT support) as there  are no differences between the
> boards in this respect.
> 
> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>

Thanks, I have queued this up for v4.4.

> ---
> This patch is against 'renesas-devel-20151008-v4.3-rc4' tag of Simon Horman's
> 'renesas.git' repo plus the Porter I2C2 and VIN0/ADV7180 patches posted earlier.
> 
>  arch/arm/boot/dts/r8a7791-porter.dts |   38 +++++++++++++++++++++++++++++++++++
>  1 file changed, 38 insertions(+)
> 
> Index: renesas/arch/arm/boot/dts/r8a7791-porter.dts
> =================================> --- renesas.orig/arch/arm/boot/dts/r8a7791-porter.dts
> +++ renesas/arch/arm/boot/dts/r8a7791-porter.dts
> @@ -110,6 +110,11 @@
>  		renesas,function = "sdhi2";
>  	};
>  
> +	qspi_pins: spi0 {
> +		renesas,groups = "qspi_ctrl", "qspi_data4";
> +		renesas,function = "qspi";
> +	};
> +
>  	i2c2_pins: i2c2 {
>  		renesas,groups = "i2c2";
>  		renesas,function = "i2c2";
> @@ -165,6 +170,39 @@
>  	status = "okay";
>  };
>  
> +&qspi {
> +	pinctrl-0 = <&qspi_pins>;
> +	pinctrl-names = "default";
> +
> +	status = "okay";
> +
> +	flash@0 {
> +		#address-cells = <1>;
> +		#size-cells = <1>;
> +		compatible = "spansion,s25fl512s", "jedec,spi-nor";

spansion,s25fl512s is used in several dt files but it seems to be
undocumented. Do we have a plan to resolve this?