Re: [RFC v2 4/5] ARM: shmobile: r8a7790: let rst module allow watchdog resets if desired

[Wolfram Sang <wsa@the-dreams.de>]

[-- Attachment #1: Type: text/plain, Size: 864 bytes --]


> > +#if defined(CONFIG_WATCHDOG)
> > +	void __iomem *p = ioremap_nocache(WDTRSTCR, 4);
> > +	BUG_ON(!p);
> > +	iowrite32(0xa55a0000, p);
> > +	iounmap(p);
> > +#endif
> 
> That's a bit of a hack. We should aim at removing code from mach-shmobile, not 
> adding new code :-) Furthermore it will cause issues with virtualization as 
> hypervisors commonly map memory based on DT, the above code will thus generate 
> a write access to an unmapped piece of memory as there's no corresponding DT 
> node.

I know. As I said in the cover letter (hint! ;)) it only works for me with
UP on Lager. These arch patches are only to be able to test the driver.
Totally not to be upstreamed.

> Time for a reset driver it seems ;-)

Can of worms for Gen2...

Let's hope it will be easier on Gen3 and we can submit the main driver
upstream this way.


[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]