From mboxrd@z Thu Jan 1 00:00:00 1970 From: Simon Horman Date: Fri, 30 Oct 2015 07:25:47 +0000 Subject: Re: [PATCH v5 2/5] arm64: dts: r8a7795: add EthernetAVB device node Message-Id: <20151030072546.GC31252@verge.net.au> List-Id: References: <1444891698-8780-1-git-send-email-horms+renesas@verge.net.au> <1444891698-8780-3-git-send-email-horms+renesas@verge.net.au> <20151030071745.GA31252@verge.net.au> In-Reply-To: <20151030071745.GA31252@verge.net.au> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: linux-arm-kernel@lists.infradead.org On Fri, Oct 30, 2015 at 04:17:46PM +0900, Simon Horman wrote: > On Thu, Oct 29, 2015 at 05:42:43PM +0900, Magnus Damm wrote: > > On Thu, Oct 15, 2015 at 3:48 PM, Simon Horman > > wrote: > > > From: Kazuya Mizuguchi > > > > > > Signed-off-by: Kazuya Mizuguchi > > > [horms: minor updates] > > > Signed-off-by: Simon Horman > > > Acked-by: Geert Uytterhoeven > > [snip] > > > Hi Simon, > > > > Thanks for your efforts with the ethernet controller. In general all > > seems good to me, but this I came across the contents of this patch > > when I was browsing the SoC DTSI file. What is the reason to put this > > node in between dmac0 and dmac1? I don't know where is the best > > location, but it would be good to keep the dmac nodes together I > > think. > > I think its just an artifact of the way the patch has been updated. > I'll see about cleaning it up. On slightly closer inspection it seems to be there due to sorting by base address. But it seems rather silly the way it is so I have it in mind to shuffle it down below the dmac nodes.