linux-sh.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Russell King - ARM Linux <linux@arm.linux.org.uk>
To: linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v3] ARM: xip: Use correct symbol for end of ROM marker
Date: Tue, 17 Nov 2015 17:33:11 +0000	[thread overview]
Message-ID: <20151117173311.GR8644@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <alpine.LFD.2.20.1511161605070.5826@knanqh.ubzr>

On Mon, Nov 16, 2015 at 04:47:12PM -0500, Nicolas Pitre wrote:
> The old method with conditional placement in the linker script is broken 
> beyond repair.  There is simply way too much stuff these days to do this 
> sanely.  I think the only way to fix it properly is to have a separate 
> linker script for XIP usage with proper (and obvious) section placement.

Absolutely the right thing to do.

The XIP stuff has been broken and getting in the way for a long time
now because of the preprocessor mess.  I've made several changes to
the linker script over the years, and each time I've ended up deciding
to I'll do the best job I can for XIP, but I'm not going to spend
too long making sure that it's correct - especially as there appeared
to be no users of it.  I wouldn't describe the current file as being
"maintainable" in any way - It has devolved into a total mess, and I
would like to see the XIP stuff gone from the non-XIP linker script
- and doing that should mean it's less likely for XIP to break.

I'd also like to see a lot more of the preprocessor gunk gone (or at
least cleaned up) in that file too...

-- 
FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up
according to speedtest.net.

      parent reply	other threads:[~2015-11-17 17:33 UTC|newest]

Thread overview: 46+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-11 14:17 [PATCH] ARM: xip: Use correct symbol for end of ROM marker Chris Brandt
2015-11-12 12:17 ` Peter Hurley
2015-11-12 13:15   ` Chris Brandt
2015-11-12 16:32 ` Russell King - ARM Linux
2015-11-12 21:01 ` [PATCH v2] " Chris Brandt
2015-11-13  7:46   ` Geert Uytterhoeven
2015-11-13 20:03     ` Chris Brandt
2015-11-16 18:05   ` [PATCH v3] " Chris Brandt
2015-11-16 18:17     ` Russell King - ARM Linux
2015-11-16 19:46       ` Chris Brandt
2015-11-16 19:53         ` Russell King - ARM Linux
2015-11-16 20:18           ` Chris Brandt
2015-11-16 20:30             ` Russell King - ARM Linux
2015-11-16 20:57       ` Nicolas Pitre
2015-11-16 21:09         ` Chris Brandt
2015-11-16 20:27     ` Nicolas Pitre
2015-11-16 21:02       ` Chris Brandt
2015-11-16 21:47         ` Nicolas Pitre
2015-11-16 22:19           ` Chris Brandt
2015-11-17  0:48             ` Nicolas Pitre
2015-11-17  2:11               ` Chris Brandt
2015-11-17  2:37                 ` Nicolas Pitre
2015-11-17 16:56                   ` Chris Brandt
2015-11-17 17:24                     ` Nicolas Pitre
2015-11-18  3:58                     ` Nicolas Pitre
2015-11-18  5:12                       ` Magnus Damm
2015-11-18 13:45                         ` Nicolas Pitre
2015-11-18 17:01                           ` Nicolas Pitre
2015-11-18 19:12                             ` Chris Brandt
2015-11-18 20:23                               ` Nicolas Pitre
2015-11-18 20:51                                 ` Chris Brandt
2015-11-18 21:36                                   ` Nicolas Pitre
2016-01-29 21:12                                     ` Chris Brandt
2016-01-29 21:17                                       ` Nicolas Pitre
2015-11-17 16:45           ` Chris Brandt
2015-11-17 16:57             ` Nicolas Pitre
2015-11-18  2:09               ` Chris Brandt
2015-11-18  3:17                 ` Nicolas Pitre
2015-11-18  8:30                   ` Arnd Bergmann
2015-11-18 15:28                     ` Chris Brandt
2015-11-18 15:16                   ` Chris Brandt
2015-11-18 17:07                     ` Nicolas Pitre
2015-11-18 19:36                       ` Chris Brandt
2015-11-18 19:44                         ` Nicolas Pitre
2015-11-18 20:00                           ` Chris Brandt
2015-11-17 17:33           ` Russell King - ARM Linux [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20151117173311.GR8644@n2100.arm.linux.org.uk \
    --to=linux@arm.linux.org.uk \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).