From: "Michael Büsch" <m@bues.ch>
To: linux-sh@vger.kernel.org, linux-kernel@vger.kernel.org,
Andrew Morton <akpm@linux-foundation.org>
Cc: Ilia Mirkin <imirkin@alum.mit.edu>
Subject: [PATCH] m32r: Fix clearing of thread info fault code
Date: Thu, 19 Nov 2015 20:12:28 +0000 [thread overview]
Message-ID: <20151119211228.396fd228@wiggum> (raw)
In-Reply-To: <20150618204518.02c852e0@wiggum>
[-- Attachment #1: Type: text/plain, Size: 669 bytes --]
The expression (~0 >> x) will always yield all-ones, because the right
shift is an arithmetic right shift that will always shift ones in.
Hence the old fault code bits will not be cleared before being ORed
with the new fault code.
Fix this by forcing a logical right shift instead of an arithmetic
right shift by using an unsigned long constant.
Reported-by: Ilia Mirkin <imirkin@alum.mit.edu>
Signed-off-by: Michael Buesch <m@bues.ch>
---
The code also assumes sizeof(ti->flags) == 4. But that probably is ok
for this arch.
This patch is untested, because I do not have the hardware.
Resend: Patch was originally sent on Wed, 18 Jun 2015.
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2015-11-19 20:12 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-18 18:45 [PATCH] m32r: Fix clearing of thread info fault code Michael Büsch
2015-11-19 20:12 ` Michael Büsch [this message]
2015-11-19 20:13 ` Michael Büsch
2015-11-19 23:08 ` Andrew Morton
2015-11-21 15:55 ` Michael Büsch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151119211228.396fd228@wiggum \
--to=m@bues.ch \
--cc=akpm@linux-foundation.org \
--cc=imirkin@alum.mit.edu \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).