linux-sh.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Simon Horman <horms@verge.net.au>
To: linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH/RFC 03/19] ARM: shmobile: gose: add i2c2 bus to device tree
Date: Mon, 14 Dec 2015 02:11:10 +0000	[thread overview]
Message-ID: <20151214021110.GD13945@verge.net.au> (raw)
In-Reply-To: <566AB2A5.4090105@cogentembedded.com>

Hi Sergei,

On Fri, Dec 11, 2015 at 02:25:25PM +0300, Sergei Shtylyov wrote:
> Hello.
> 
> On 12/11/2015 5:52 AM, Simon Horman wrote:
> 
> >Activate i2c2 bus in r8a7793/gose device tree.
> >
> >Based on similar work for the r8a7791/koelsch by Wolfram Sang.
> >
> >Cc: Wolfram Sang <wsa@sang-engineering.com>
> >Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
> >---
> >  arch/arm/boot/dts/r8a7793-gose.dts | 19 +++++++++++++++++++
> >  1 file changed, 19 insertions(+)
> >
> >diff --git a/arch/arm/boot/dts/r8a7793-gose.dts b/arch/arm/boot/dts/r8a7793-gose.dts
> >index 3e3122490650..9a71ff6d4474 100644
> >--- a/arch/arm/boot/dts/r8a7793-gose.dts
> >+++ b/arch/arm/boot/dts/r8a7793-gose.dts
> [...]
> >@@ -135,3 +140,17 @@
> >  		};
> >  	};
> >  };
> >+
> >+&i2c2 {
> >+	pinctrl-0 = <&i2c2_pins>;
> >+	pinctrl-names = "default";
> >+
> >+	status = "okay";
> >+	clock-frequency = <100000>;
> >+
> >+	eeprom@50 {
> >+		compatible = "renesas,24c02";
> 
>    This is not a valid value -- the Renesas chip model is different from 24c02.

I copied this value from r8a7791.dtsi.

Looking at the schematic for gose (v100), koelsch (rev024) and porter (v300)
I see the following "R1EX24002ATAS0G#U0". Shall we update r8a7791 and
this patch to "renesas,24002" or leave things as is?

  reply	other threads:[~2015-12-14  2:11 UTC|newest]

Thread overview: 45+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-12-11  2:52 [PATCH/RFC 00/19] r8a7793, gose: Add i2c and audio support to device tree Simon Horman
2015-12-11  2:52 ` [PATCH/RFC 01/19] ARM: shmobile: r8a7793: add i2c clocks Simon Horman
2015-12-13 18:59   ` Laurent Pinchart
2015-12-11  2:52 ` [PATCH/RFC 02/19] ARM: shmobile: r8a7793: add i2c to device tree Simon Horman
2015-12-11  2:52 ` [PATCH/RFC 03/19] ARM: shmobile: gose: add i2c2 bus " Simon Horman
2015-12-11 11:25   ` Sergei Shtylyov
2015-12-14  2:11     ` Simon Horman [this message]
2015-12-14  7:11       ` Wolfram Sang
2015-12-14  9:39         ` Geert Uytterhoeven
2015-12-18  3:02           ` Simon Horman
2015-12-18  7:35             ` I2C eeprom compatibles? (was Re: [PATCH/RFC 03/19] ARM: shmobile: gose: add i2c2 bus to device tree) Wolfram Sang
2015-12-18  9:06               ` I2C eeprom compatibles? (was Re: [PATCH/RFC 03/19] ARM: shmobile: gose: add i2c2 bus to device t Arnd Bergmann
2015-12-18 10:32                 ` Wolfram Sang
2015-12-21  4:33                   ` Simon Horman
2015-12-21  8:02                     ` Geert Uytterhoeven
2015-12-14 17:03       ` [PATCH/RFC 03/19] ARM: shmobile: gose: add i2c2 bus to device tree Sergei Shtylyov
2015-12-11  2:52 ` [PATCH/RFC 04/19] ARM: shmobile: r8a7793: add iic(b) " Simon Horman
2015-12-11  9:40   ` Geert Uytterhoeven
2015-12-14  2:21     ` Simon Horman
2015-12-14  8:13       ` Geert Uytterhoeven
2015-12-11  2:52 ` [PATCH/RFC 05/19] ARM: shmobile: r8a7793: add MSTP10 clocks " Simon Horman
2015-12-14  1:00   ` Kuninori Morimoto
2015-12-14  1:47     ` Simon Horman
2015-12-14  3:49       ` Kuninori Morimoto
2015-12-14  9:41       ` Geert Uytterhoeven
2015-12-11  2:52 ` [PATCH/RFC 06/19] ARM: shmobile: r8a7793: add audio clock " Simon Horman
2015-12-11  2:52 ` [PATCH/RFC 07/19] ARM: shmobile: r8a7793: add m2 " Simon Horman
2015-12-13 18:56   ` Laurent Pinchart
2015-12-11  2:52 ` [PATCH/RFC 08/19] ARM: shmobile: r8a7793: add R-Car sound support " Simon Horman
2015-12-11  9:44   ` Geert Uytterhoeven
2015-12-14  1:49     ` Simon Horman
2015-12-11  2:52 ` [PATCH/RFC 09/19] ARM: shmobile: r8a7793: add DVC " Simon Horman
2015-12-11  2:52 ` [PATCH/RFC 10/19] ARM: shmobile: r8a7793: add audio DMAC clocks " Simon Horman
2015-12-11  2:52 ` [PATCH/RFC 11/19] ARM: shmobile: r8a7793: add audio DMAC " Simon Horman
2015-12-11  2:52 ` [PATCH/RFC 12/19] ARM: shmobile: gose: Enable sound PIO support in " Simon Horman
2015-12-11  2:52 ` [PATCH/RFC 13/19] ARM: shmobile: gose: enable sound DMA " Simon Horman
2015-12-11  2:52 ` [PATCH/RFC 14/19] ARM: shmobile: gose: enable sound DMA support via BUSIF " Simon Horman
2015-12-11  2:52 ` [PATCH/RFC 15/19] ARM: shmobile: gose: enable sound DMA support via SRC " Simon Horman
2015-12-11  2:52 ` [PATCH/RFC 16/19] ARM: shmobile: gose: enable sound DMA support via DVC " Simon Horman
2015-12-11  2:52 ` [PATCH/RFC 17/19] ARM: shmobile: r8a7793: enable audio DMAC " Simon Horman
2015-12-11  2:52 ` [PATCH/RFC 18/19] ARM: shmobile: r8a7793: Add Audio CTU support to " Simon Horman
2015-12-11  2:52 ` [PATCH/RFC 19/19] ARM: shmobile: r8a7793: add Audio MIX " Simon Horman
2015-12-14  1:07   ` Kuninori Morimoto
2015-12-14  1:54     ` Simon Horman
2015-12-11  9:45 ` [PATCH/RFC 00/19] r8a7793, gose: Add i2c and audio " Geert Uytterhoeven

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20151214021110.GD13945@verge.net.au \
    --to=horms@verge.net.au \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).