From mboxrd@z Thu Jan 1 00:00:00 1970 From: Simon Horman Date: Mon, 14 Dec 2015 05:19:06 +0000 Subject: Re: [PATCH 07/10] drivers/pci: make host/pcie-rcar.c explicitly non-modular Message-Id: <20151214051906.GF18143@verge.net.au> List-Id: References: <1449970917-12633-1-git-send-email-paul.gortmaker@windriver.com> <1449970917-12633-8-git-send-email-paul.gortmaker@windriver.com> In-Reply-To: <1449970917-12633-8-git-send-email-paul.gortmaker@windriver.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Paul Gortmaker Cc: linux-kernel@vger.kernel.org, Bjorn Helgaas , linux-pci@vger.kernel.org, linux-sh@vger.kernel.org On Sat, Dec 12, 2015 at 08:41:54PM -0500, Paul Gortmaker wrote: > The Kconfig currently controlling compilation of this code is: > > drivers/pci/host/Kconfig:config PCI_RCAR_GEN2_PCIE > drivers/pci/host/Kconfig: bool "Renesas R-Car PCIe controller" > > ...meaning that it currently is not being built as a module by anyone. > > Lets remove the modular code that is essentially orphaned, so that > when reading the driver there is no doubt it is builtin-only. > > Since module_platform_driver() uses the same init level priority as > builtin_platform_driver() the init ordering remains unchanged with > this commit. > > We don't have to disallow a driver unbind, since that is already > done for us in this driver. > > Also note that MODULE_DEVICE_TABLE is a no-op for non-modular code. > > We also delete the MODULE_LICENSE tag etc. since all that information > was (or is now) contained at the top of the file in the comments. > > Cc: Simon Horman > Cc: Bjorn Helgaas > Cc: linux-pci@vger.kernel.org > Cc: linux-sh@vger.kernel.org > Signed-off-by: Paul Gortmaker Acked-by: Simon Horman