Re: [PATCH] ARM: shmobile: alt: Add QSPI device to DT

[Simon Horman <horms@verge.net.au>]

On Tue, Dec 01, 2015 at 09:06:17AM +0100, Geert Uytterhoeven wrote:
> Hi Simon,
> 
> On Tue, Dec 1, 2015 at 7:41 AM, Simon Horman <horms@verge.net.au> wrote:
> > On Mon, Nov 30, 2015 at 09:34:10AM +0100, Geert Uytterhoeven wrote:
> >> On Mon, Nov 30, 2015 at 7:13 AM, Simon Horman
> >> <horms+renesas@verge.net.au> wrote:
> >> > Enable the QSPI controller in the alt device tree.
> >> >
> >> > Based similar work for the silk board by by Vladimir Barinov and
> >> > Sergei Shtylyov.
> >> >
> >> > Cc: Vladimir Barinov <vladimir.barinov@cogentembedded.com>
> >> > Cc: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
> >> > Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
> >>
> >> Verified against Alt schematics and r8a7794 datasheet.
> >>
> >> Acked-by: Geert Uytterhoeven <geert+renesas@glider.be>
> >>
> >> I can't verify the FLASH layout. Note that p.11 of
> >> ALT_MiniMonitor_Manual(SPI_Boot)_Rev0.01_e.pdf shows a different
> >> FLASH layout for the second and third partition.
> >
> > Thanks. I see the following in v1.9.6 of the BSP[1]. Is it
> > the same as the document you referred to above?
> >
> >
> >                 partition@0 {
> >                         label = "loader";
> >                         reg = <0x00000000 0x00080000>;
> >                         read-only;
> >                 };
> >                 partition@40000 {
> >                         label = "user";
> >                         reg = <0x00080000 0x00580000>;
> >                         read-only;
> >                 };
> >                 partition@440000 {
> >                         label = "flash";
> >                         reg = <0x00600000 0x03a00000>;
> >                 };
> >
> >
> > [1] https://git.kernel.org/cgit/linux/kernel/git/horms/renesas-backport.git/tree/arch/arm/boot/dts/r8a7794-alt.dts?h=rcar-gen2/v1.9.6&idáacbe074f36d96e901bf5346c50ee51da2ced42#n379
> 
> No, the document specifies 3 partitions:
>   - SA0: loader program area, 16 KiB,
>   - SA1: System area, 16 KiB,
>   - SA2: User program area, remainder.
> 
> FWIW, the unit addresses in the device nodes above are not consistent
> with their reg properties.

My feeling is that we should follow the documentation.
Does this reflect the scheme it describes?


                partitions {
                        #address-cells = <1>;
                        #size-cells = <1>;

                        partition@0 {
                                label = "loader";
                                reg = <0x00000000 0x00004000>;
                                read-only;
                        };
                        partition@4000 {
                                label = "system";
                                reg = <0x00004000 0x00004000>;
                                read-only;
                        };
                        partition@8000 {
                                label = "user";
                                reg = <0x00008000 0x03ff8000>;
                        };
                };