linux-sh.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Simon Horman <horms@verge.net.au>
To: linux-sh@vger.kernel.org
Subject: Re: [PATCH] ARM: shmobile: r8a7793: Add I2C master nodes to DT
Date: Sun, 03 Jan 2016 21:59:36 +0000	[thread overview]
Message-ID: <20160103215935.GE22806@verge.net.au> (raw)
In-Reply-To: <1451299221-18679-1-git-send-email-laurent.pinchart+renesas@ideasonboard.com>

On Wed, Dec 30, 2015 at 12:46:32AM +0200, Laurent Pinchart wrote:
> Hi Simon,
> 
> On Wednesday 30 December 2015 09:32:52 Simon Horman wrote:
> > On Mon, Dec 28, 2015 at 12:40:21PM +0200, Laurent Pinchart wrote:
> > > Instantiate all the 9 I2C controllers in the disabled state.
> > > 
> > > Signed-off-by: Laurent Pinchart
> > > <laurent.pinchart+renesas@ideasonboard.com>
> > 
> > I took a slightly different approach for the last 3 controllers in:
> > 
> > * [PATCH/RFC 01/19] ARM: shmobile: r8a7793: add i2c clocks
> > * [PATCH/RFC 04/19] ARM: shmobile: r8a7793: add iic(b)  to device tree
> > 
> > I'm wondering if we could reach some consensus on how to handle that.
> > If that seems difficult perhaps we could just enable the first 6
> > controllers for now.
> 
> I'm fine with any approach. This is a case where discussing how to implement 
> the feature will take longer than implementing it, so feel free to drop my 
> patch and use yours :-)

Point taken.

I have queued up your version on the basis that the implementation matches
that of the r8a7791, the closes relative of the r8a7793 in hardware terms.
We can do a dance around re-arranging things, as my patches suggested,
if the need arises.

      parent reply	other threads:[~2016-01-03 21:59 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-12-28 10:40 [PATCH] ARM: shmobile: r8a7793: Add I2C master nodes to DT Laurent Pinchart
2015-12-29 22:32 ` Simon Horman
2015-12-29 22:46 ` Laurent Pinchart
2016-01-03 21:59 ` Simon Horman [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160103215935.GE22806@verge.net.au \
    --to=horms@verge.net.au \
    --cc=linux-sh@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).