From: Simon Horman <horms@verge.net.au>
To: Yoshihiro Kaneko <ykaneko0929@gmail.com>
Cc: netdev@vger.kernel.org, "David S. Miller" <davem@davemloft.net>,
Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>,
Magnus Damm <magnus.damm@gmail.com>,
linux-sh@vger.kernel.org
Subject: Re: [PATCH/RFC v4 net-next] ravb: Add dma queue interrupt support
Date: Tue, 26 Jan 2016 00:23:01 +0000 [thread overview]
Message-ID: <20160126002300.GA27856@verge.net.au> (raw)
In-Reply-To: <1453650775-19886-1-git-send-email-ykaneko0929@gmail.com>
On Mon, Jan 25, 2016 at 12:52:55AM +0900, Yoshihiro Kaneko wrote:
> From: Kazuya Mizuguchi <kazuya.mizuguchi.ks@renesas.com>
>
> This patch supports the following interrupts.
>
> - One interrupt for multiple (descriptor, error, management)
> - One interrupt for emac
> - Four interrupts for dma queue (best effort rx/tx, network control rx/tx)
>
> This patch improve efficiency of the interrupt handler by adding the
> interrupt handler corresponding to each interrupt source described
> above. Additionally, it reduces the number of times of the access to
> EthernetAVB IF.
>
> Signed-off-by: Kazuya Mizuguchi <kazuya.mizuguchi.ks@renesas.com>
> Signed-off-by: Yoshihiro Kaneko <ykaneko0929@gmail.com>
I have tested this patch and the result seems positive.
Please let me know if any more/different testing would help.
My test was to examine /proc/interrupts after booting a Salvator-X board
using NFS root. The test used net-next merged with v4.5-rc1 (for
r8a7795/Salvator-X support). I then applied this patch.
Without this patch:
# grep eth /proc/interrupts
74: 13002 0 0 0 GIC-0 93 Level eth0
76: 3 0 0 0 GIC-0 95 Level eth0
With this patch:
# grep eth /proc/interrupts
52: 8744 0 0 0 GIC-0 71 Level eth0:ch0:rx_be
53: 0 0 0 0 GIC-0 72 Level eth0:ch1:rx_nc
70: 4277 0 0 0 GIC-0 89 Level eth0:ch18:tx_be
71: 0 0 0 0 GIC-0 90 Level eth0:ch19:tx_nc
74: 0 0 0 0 GIC-0 93 Level eth0:ch22:multi
76: 3 0 0 0 GIC-0 95 Level eth0:ch24:emac
Please feel free to add:
Tested-by: Simon Horman <horms+renesas@verge.net.au>
next prev parent reply other threads:[~2016-01-26 0:23 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-24 15:52 [PATCH/RFC v4 net-next] ravb: Add dma queue interrupt support Yoshihiro Kaneko
2016-01-26 0:23 ` Simon Horman [this message]
2016-01-26 19:00 ` Sergei Shtylyov
2016-01-27 1:49 ` Simon Horman
2016-01-28 15:50 ` Sergei Shtylyov
2016-01-28 18:36 ` Sergei Shtylyov
2016-01-28 16:48 ` Sergei Shtylyov
2016-02-07 16:50 ` Yoshihiro Kaneko
2016-02-07 17:09 ` Sergei Shtylyov
2016-02-08 17:19 ` Yoshihiro Kaneko
2016-02-21 15:42 ` Sergei Shtylyov
2016-02-21 19:16 ` Sergei Shtylyov
2016-02-25 22:22 ` Sergei Shtylyov
2016-01-28 17:32 ` Sergei Shtylyov
2016-02-07 16:56 ` Yoshihiro Kaneko
2016-02-07 17:18 ` Sergei Shtylyov
2016-01-28 17:51 ` Sergei Shtylyov
2016-02-07 17:18 ` Yoshihiro Kaneko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160126002300.GA27856@verge.net.au \
--to=horms@verge.net.au \
--cc=davem@davemloft.net \
--cc=linux-sh@vger.kernel.org \
--cc=magnus.damm@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=sergei.shtylyov@cogentembedded.com \
--cc=ykaneko0929@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).