From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Hildenbrand Date: Mon, 29 Feb 2016 11:03:38 +0000 Subject: Re: sh7724 regression: commit 8222dbe21e79338de92d5e1956cd1e3994cc9f93 Message-Id: <20160229120338.1172e5f5@thinkpad-w530> List-Id: References: In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: linux-sh@vger.kernel.org > On 02/29/2016 09:24 AM, David Hildenbrand wrote: > >> On 02/27/2016 03:28 PM, John Paul Adrian Glaubitz wrote: > >>> Hi Hans! > >>> > >>> On 02/27/2016 03:20 PM, Geert Uytterhoeven wrote: > >>>>> I noticed that 4.1 was ok and v4.2 wasn't, so I did a git bisect and ended up with > >>>>> commit 8222dbe21e79338de92d5e1956cd1e3994cc9f93 (sched/preempt, mm/fault: Decouple > >>>>> preemption from the page fault logic) as the culprit. > >>> > >>> If you like, please report this the kernel bug tracker and set > >>> "Hardware" to "SuperH". This way we are able to keep track of > >>> the issue. > >>> > >>> I think Yoshinori Sato and Rich Felker will have a look at this. > >>> > >>> Adrian > >>> > >> > >> Done: https://bugzilla.kernel.org/show_bug.cgi?id3321 > >> > >> Regards, > >> > >> Hans > >> > > > > Looks like the code then requires to not be allowed to sleep/preempt in these > > sections (just like kmap_atomic, or kmap_coherent on mips). > > > > So the fix should be simple as (untested): > > That fixes it for me: > > Tested-by: Hans Verkuil > > BTW, your patch is garbled and I had to manually make the change (not a big > deal for a simple change like this). > Thanks for testing. I just copy-pasted the patch, so this was somehow expected :) @maintainers, how to proceed with this? Shall I send that patch again directly to the linux-sh list? David