Re: [RFC v4 1/4] watchdog: renesas-rwdt: add driver

[Wolfram Sang <wsa@the-dreams.de>]

[-- Attachment #1: Type: text/plain, Size: 980 bytes --]


> > What about "renesas,rcar-gen2-rwdt" since Gen2 and Gen3 are identical?
> 
> Are they? :-) Yes, at the datasheet level, FWIW...

OK.

> > But why "r8a7795-rwdt" with SoC first? Looking at the r8a7795.dtsi,
> > "<ip_core>-<soc_type>" seems to be more dominant than
> > "<soc_type>-<ip_core>"? Ah, confusing again...
> 
> For new bindings, we follow practices set by the rest of the DT crowd.

OK.

> >> > +       if (!rate)
> >> > +               return -ENOENT;
> >>
> >> -EINVAL?
> >
> > Too generic.
> 
> A clock with a zero rate doesn't mean that the clock doesn't exist.

Using different ERRNOs, you see immediately which error path was taken
and what you need to fix (without adding printouts to the driver because
you don't know which -EINVAL triggered). I consider this more helpful
than being pedantic on the error namings (since they are only reported
by the driver core and not exposed to userspace).

So, I don't wanna change this.


[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]