linux-sh.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Simon Horman <horms@verge.net.au>
To: linux-sh@vger.kernel.org
Subject: Re: [RFC v4 1/4] watchdog: renesas-rwdt: add driver
Date: Fri, 18 Mar 2016 00:18:55 +0000	[thread overview]
Message-ID: <20160318001852.GA17140@verge.net.au> (raw)
In-Reply-To: <1452287553-18895-2-git-send-email-wsa@the-dreams.de>

On Thu, Mar 17, 2016 at 10:48:29AM +0100, Geert Uytterhoeven wrote:
> Hi Wolfram,
> 
> On Thu, Mar 17, 2016 at 10:34 AM, Wolfram Sang <wsa@the-dreams.de> wrote:
> >> > +Required properties:
> >> > +- compatible : Should be "renesas,rwdt-r8a7795";
> >>
> >> "renesas,r8a7795-rwdt", and "renesas,rcar-gen3-rwdt" as a fallback, to match
> >> current best practices?
> >
> > What about "renesas,rcar-gen2-rwdt" since Gen2 and Gen3 are identical?
> 
> Are they? :-) Yes, at the datasheet level, FWIW...

How about "renesas,rcar-gen2-rwdt" and "renesas,rcar-gen3-rwdt".
That way we have flexibility if the IP turns out to be different.
This is in keeping with the scheme I have been slowly rolling
out over various drivers for Renesas IP.

> > But why "r8a7795-rwdt" with SoC first? Looking at the r8a7795.dtsi,
> > "<ip_core>-<soc_type>" seems to be more dominant than
> > "<soc_type>-<ip_core>"? Ah, confusing again...
> 
> For new bindings, we follow practices set by the rest of the DT crowd.

+1

  parent reply	other threads:[~2016-03-18  0:18 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-01-08 21:12 [RFC v4 1/4] watchdog: renesas-rwdt: add driver Wolfram Sang
2016-01-14 17:30 ` Geert Uytterhoeven
2016-03-17  9:34 ` Wolfram Sang
2016-03-17  9:48 ` Geert Uytterhoeven
2016-03-17 10:09 ` Wolfram Sang
2016-03-18  0:18 ` Simon Horman [this message]
2016-03-18  8:27 ` Wolfram Sang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160318001852.GA17140@verge.net.au \
    --to=horms@verge.net.au \
    --cc=linux-sh@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).