From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sergey Senozhatsky Date: Wed, 27 Apr 2016 00:34:09 +0000 Subject: Re: [PATCH v5 4/4] printk/nmi: flush NMI messages on the system panic Message-Id: <20160427003409.GA4782@swordfish> List-Id: References: <1461239325-22779-1-git-send-email-pmladek@suse.com> <1461239325-22779-5-git-send-email-pmladek@suse.com> <20160423034924.GA535@swordfish> <20160426142157.GK2749@pathway.suse.cz> In-Reply-To: <20160426142157.GK2749@pathway.suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: linux-arm-kernel@lists.infradead.org On (04/26/16 16:21), Petr Mladek wrote: [..] > > move printk_nmi_flush_on_panic() to printk.c, and place it next to > > printk_flush_on_panic() (so we will have two printk "flush-on-panic" > > functions sitting together). /* printk_nmi_flush() is in printk.h, > > so it's visible to printk anyway */ > > > > it also will let us keep logbuf_lock static, it's a bit too internal > > to printk to expose it, I think. > > > > IOW, something like this? > > It is rather cosmetic change. I oh yes, it is. just to keep similar functionality (flush, zap locks) in one place (printk). -ss