From: Russell King - ARM Linux <linux@arm.linux.org.uk>
To: linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v5 2/4] printk/nmi: warn when some message has been lost in NMI context
Date: Wed, 27 Apr 2016 09:34:38 +0000 [thread overview]
Message-ID: <20160427093438.GK19428@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <1461239325-22779-3-git-send-email-pmladek@suse.com>
On Thu, Apr 21, 2016 at 01:48:43PM +0200, Petr Mladek wrote:
> @@ -64,8 +65,10 @@ static int vprintk_nmi(const char *fmt, va_list args)
> again:
> len = atomic_read(&s->len);
>
> - if (len >= sizeof(s->buffer))
> + if (len >= sizeof(s->buffer)) {
> + atomic_inc(&nmi_message_lost);
This should be fine - I think its reasonable to expect that no one is
using a spinlock implementation for their atomic ops for this...
--
RMK's Patch system: http://www.arm.linux.org.uk/developer/patches/
FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up
according to speedtest.net.
next prev parent reply other threads:[~2016-04-27 9:34 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-21 11:48 [PATCH v5 0/4] Cleaning printk stuff in NMI context Petr Mladek
2016-04-21 11:48 ` [PATCH v5 1/4] printk/nmi: generic solution for safe printk in NMI Petr Mladek
2016-04-27 9:31 ` Russell King - ARM Linux
2017-04-19 17:13 ` Steven Rostedt
2017-04-19 17:21 ` Peter Zijlstra
2017-04-20 3:31 ` Sergey Senozhatsky
2017-04-20 13:11 ` Petr Mladek
2017-04-21 1:57 ` Sergey Senozhatsky
2017-04-21 12:06 ` Petr Mladek
2017-04-24 2:17 ` Sergey Senozhatsky
2017-04-27 13:38 ` Petr Mladek
2017-04-27 14:31 ` Steven Rostedt
2017-04-27 15:28 ` Petr Mladek
2017-04-27 15:42 ` Steven Rostedt
2017-04-28 9:02 ` Peter Zijlstra
2017-04-28 13:44 ` Petr Mladek
2017-04-28 13:58 ` Peter Zijlstra
2017-04-28 14:47 ` Steven Rostedt
2017-04-27 16:14 ` Steven Rostedt
2017-04-28 1:35 ` Sergey Senozhatsky
2017-04-28 12:57 ` Petr Mladek
2017-04-28 14:16 ` Steven Rostedt
2017-04-28 1:25 ` Sergey Senozhatsky
2017-04-28 12:38 ` Petr Mladek
2016-04-21 11:48 ` [PATCH v5 2/4] printk/nmi: warn when some message has been lost in NMI context Petr Mladek
2016-04-27 9:34 ` Russell King - ARM Linux [this message]
2016-04-21 11:48 ` [PATCH v5 3/4] printk/nmi: increase the size of NMI buffer and make it configurable Petr Mladek
2016-04-21 11:48 ` [PATCH v5 4/4] printk/nmi: flush NMI messages on the system panic Petr Mladek
2016-04-23 3:49 ` Sergey Senozhatsky
2016-04-26 14:21 ` Petr Mladek
2016-04-27 0:34 ` Sergey Senozhatsky
2016-04-27 0:36 ` [PATCH v5 0/4] Cleaning printk stuff in NMI context Sergey Senozhatsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160427093438.GK19428@n2100.arm.linux.org.uk \
--to=linux@arm.linux.org.uk \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).