From: Jason Cooper <jason@lakedaemon.net>
To: Rich Felker <dalias@libc.org>,
Thomas Gleixner <tglx@linutronix.de>,
Marc Zyngier <marc.zyngier@arm.com>
Cc: linux-kernel@vger.kernel.org, linux-sh@vger.kernel.org,
Jason Cooper <jason@lakedaemon.net>
Subject: [PATCH] sh: Fix building j2_defconfig
Date: Tue, 16 Aug 2016 15:41:40 +0000 [thread overview]
Message-ID: <20160816154140.25022-1-jason@lakedaemon.net> (raw)
When targeting the j2, we need to retain '-m2'. Previously, the
Makefile blew out -m2 on the next line via :=.
Fix this by s/:=/+=/ when building for the J2.
Fixes: 5a846abad07f6 ("sh: add support for J-Core J2 processor")
Signed-off-by: Jason Cooper <jason@lakedaemon.net>
---
Thanks to Richard Felker for helping me locate the problem.
arch/sh/Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/sh/Makefile b/arch/sh/Makefile
index 00476662ac2c..336f33a419d9 100644
--- a/arch/sh/Makefile
+++ b/arch/sh/Makefile
@@ -31,7 +31,7 @@ isa-y := $(isa-y)-up
endif
cflags-$(CONFIG_CPU_SH2) := $(call cc-option,-m2,)
-cflags-$(CONFIG_CPU_J2) := $(call cc-option,-mj2,)
+cflags-$(CONFIG_CPU_J2) += $(call cc-option,-mj2,)
cflags-$(CONFIG_CPU_SH2A) += $(call cc-option,-m2a,) \
$(call cc-option,-m2a-nofpu,) \
$(call cc-option,-m4-nofpu,)
--
2.9.3
next reply other threads:[~2016-08-16 15:41 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-16 15:41 Jason Cooper [this message]
2016-08-16 21:15 ` [PATCH] sh: Fix building j2_defconfig Rob Landley
2016-08-16 21:23 ` Jason Cooper
2016-08-20 3:40 ` Rob Landley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160816154140.25022-1-jason@lakedaemon.net \
--to=jason@lakedaemon.net \
--cc=dalias@libc.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
--cc=marc.zyngier@arm.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).