From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Lee Jones <lee.jones@linaro.org>
Cc: Wolfram Sang <wsa@the-dreams.de>,
linux-i2c@vger.kernel.org,
Yoshinori Sato <ysato@users.sourceforge.jp>,
Rich Felker <dalias@libc.org>,
linux-sh@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-input@vger.kernel.org
Subject: Re: [PATCH 4/4] input: tsc2007: move header file out of I2C realm
Date: Mon, 22 May 2017 20:54:16 +0000 [thread overview]
Message-ID: <20170522205416.GA12016@dtor-ws> (raw)
In-Reply-To: <20170522074105.umwz723mvkxxmcnj@dell>
On Mon, May 22, 2017 at 08:41:05AM +0100, Lee Jones wrote:
> On Sun, 21 May 2017, Wolfram Sang wrote:
>
> > include/linux/i2c is not for client devices. Move the header file to a
> > more appropriate location.
> >
> > Signed-off-by: Wolfram Sang <wsa@the-dreams.de>
> > ---
> > arch/sh/boards/mach-ecovec24/setup.c | 2 +-
> > drivers/input/touchscreen/tsc2007_core.c | 2 +-
> > drivers/mfd/timberdale.c | 2 +-
>
> Acked-by: Lee Jones <lee.jones@linaro.org>
>
> > include/linux/{i2c => input}/tsc2007.h | 2 +-
> > 4 files changed, 4 insertions(+), 4 deletions(-)
> > rename include/linux/{i2c => input}/tsc2007.h (95%)
This should really go into include/linux/platform_data/, not into
input/, for the same reason you are moving it out of i2c. I'd also like
to get rid of platform data for tsc2007 altogether...
I guess I'll take it (moving to platform_data/) so I can work on generic
properties...
Thanks.
--
Dmitry
prev parent reply other threads:[~2017-05-22 20:54 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-21 20:40 [PATCH 0/4] input: move include files out of include/linux/i2c Wolfram Sang
2017-05-21 20:40 ` [PATCH 4/4] input: tsc2007: move header file out of I2C realm Wolfram Sang
2017-05-22 7:41 ` Lee Jones
2017-05-22 20:54 ` Dmitry Torokhov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170522205416.GA12016@dtor-ws \
--to=dmitry.torokhov@gmail.com \
--cc=dalias@libc.org \
--cc=lee.jones@linaro.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
--cc=wsa@the-dreams.de \
--cc=ysato@users.sourceforge.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).