* [PATCH 0/4] input: move include files out of include/linux/i2c
@ 2017-05-21 20:40 Wolfram Sang
2017-05-21 20:40 ` [PATCH 4/4] input: tsc2007: move header file out of I2C realm Wolfram Sang
0 siblings, 1 reply; 4+ messages in thread
From: Wolfram Sang @ 2017-05-21 20:40 UTC (permalink / raw)
To: linux-i2c; +Cc: Wolfram Sang, linux-input, linux-kernel, linux-sh
It doesn't make sense to use include/linux/i2c for client drivers which may in
fact rather be hwmon or input or whatever devices. As a result, I want to
deprecate include/linux/i2c for good. This series moves the include files to a
better location, for the input subsystem to include/linux/input. If you prefer
include/linux/platform_data, because that is what most of the moved include
files contain, let me know. Note that some files don't seem to have upstream
users in board code, so they maybe could even be removed? I didn't check for
that now, but I did it for one i2c master driver recently. So, it may be
possible.
I prefer the series to go upstream via the subsystem tree; if you prefer that I
take it via I2C, just let me know.
No runtime testing because of no HW, but buildbot is happy with this series at
least. A branch can be found here:
git://git.kernel.org/pub/scm/linux/kernel/git/wsa/linux.git i2c/platform_data
Thanks and kind regards,
Wolfram
Wolfram Sang (4):
input: lm8323: move header file out of I2C realm
input: mcs: move header file out of I2C realm
input: mms114: move header file out of I2C realm
input: tsc2007: move header file out of I2C realm
arch/sh/boards/mach-ecovec24/setup.c | 2 +-
drivers/input/keyboard/lm8323.c | 2 +-
drivers/input/keyboard/mcs_touchkey.c | 2 +-
drivers/input/touchscreen/mcs5000_ts.c | 2 +-
drivers/input/touchscreen/mms114.c | 2 +-
drivers/input/touchscreen/tsc2007_core.c | 2 +-
drivers/mfd/timberdale.c | 2 +-
include/linux/{i2c => input}/lm8323.h | 0
include/linux/{i2c => input}/mcs.h | 0
include/linux/{i2c => input}/mms114.h | 0
include/linux/{i2c => input}/tsc2007.h | 2 +-
11 files changed, 8 insertions(+), 8 deletions(-)
rename include/linux/{i2c => input}/lm8323.h (100%)
rename include/linux/{i2c => input}/mcs.h (100%)
rename include/linux/{i2c => input}/mms114.h (100%)
rename include/linux/{i2c => input}/tsc2007.h (95%)
--
2.11.0
^ permalink raw reply [flat|nested] 4+ messages in thread* [PATCH 4/4] input: tsc2007: move header file out of I2C realm
2017-05-21 20:40 [PATCH 0/4] input: move include files out of include/linux/i2c Wolfram Sang
@ 2017-05-21 20:40 ` Wolfram Sang
2017-05-22 7:41 ` Lee Jones
0 siblings, 1 reply; 4+ messages in thread
From: Wolfram Sang @ 2017-05-21 20:40 UTC (permalink / raw)
To: linux-i2c
Cc: Wolfram Sang, Yoshinori Sato, Rich Felker, Dmitry Torokhov,
Lee Jones, linux-sh, linux-kernel, linux-input
include/linux/i2c is not for client devices. Move the header file to a
more appropriate location.
Signed-off-by: Wolfram Sang <wsa@the-dreams.de>
---
arch/sh/boards/mach-ecovec24/setup.c | 2 +-
drivers/input/touchscreen/tsc2007_core.c | 2 +-
drivers/mfd/timberdale.c | 2 +-
include/linux/{i2c => input}/tsc2007.h | 2 +-
4 files changed, 4 insertions(+), 4 deletions(-)
rename include/linux/{i2c => input}/tsc2007.h (95%)
diff --git a/arch/sh/boards/mach-ecovec24/setup.c b/arch/sh/boards/mach-ecovec24/setup.c
index 6d612792f6b8ec..efca883d3466cc 100644
--- a/arch/sh/boards/mach-ecovec24/setup.c
+++ b/arch/sh/boards/mach-ecovec24/setup.c
@@ -24,7 +24,7 @@
#include <linux/usb/r8a66597.h>
#include <linux/usb/renesas_usbhs.h>
#include <linux/i2c.h>
-#include <linux/i2c/tsc2007.h>
+#include <linux/input/tsc2007.h>
#include <linux/spi/spi.h>
#include <linux/spi/sh_msiof.h>
#include <linux/spi/mmc_spi.h>
diff --git a/drivers/input/touchscreen/tsc2007_core.c b/drivers/input/touchscreen/tsc2007_core.c
index fc7384936011dc..b680b942e4abde 100644
--- a/drivers/input/touchscreen/tsc2007_core.c
+++ b/drivers/input/touchscreen/tsc2007_core.c
@@ -25,7 +25,7 @@
#include <linux/input.h>
#include <linux/interrupt.h>
#include <linux/i2c.h>
-#include <linux/i2c/tsc2007.h>
+#include <linux/input/tsc2007.h>
#include <linux/of_device.h>
#include <linux/of_gpio.h>
#include "tsc2007.h"
diff --git a/drivers/mfd/timberdale.c b/drivers/mfd/timberdale.c
index c9339f85359b74..84523b630e2fdf 100644
--- a/drivers/mfd/timberdale.c
+++ b/drivers/mfd/timberdale.c
@@ -32,7 +32,7 @@
#include <linux/i2c.h>
#include <linux/i2c-ocores.h>
#include <linux/i2c-xiic.h>
-#include <linux/i2c/tsc2007.h>
+#include <linux/input/tsc2007.h>
#include <linux/spi/spi.h>
#include <linux/spi/xilinx_spi.h>
diff --git a/include/linux/i2c/tsc2007.h b/include/linux/input/tsc2007.h
similarity index 95%
rename from include/linux/i2c/tsc2007.h
rename to include/linux/input/tsc2007.h
index 4f35b6ad3889fa..c7b7eb024328d5 100644
--- a/include/linux/i2c/tsc2007.h
+++ b/include/linux/input/tsc2007.h
@@ -1,7 +1,7 @@
#ifndef __LINUX_I2C_TSC2007_H
#define __LINUX_I2C_TSC2007_H
-/* linux/i2c/tsc2007.h */
+/* linux/input/tsc2007.h */
struct tsc2007_platform_data {
u16 model; /* 2007. */
--
2.11.0
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH 4/4] input: tsc2007: move header file out of I2C realm
2017-05-21 20:40 ` [PATCH 4/4] input: tsc2007: move header file out of I2C realm Wolfram Sang
@ 2017-05-22 7:41 ` Lee Jones
2017-05-22 20:54 ` Dmitry Torokhov
0 siblings, 1 reply; 4+ messages in thread
From: Lee Jones @ 2017-05-22 7:41 UTC (permalink / raw)
To: Wolfram Sang
Cc: linux-i2c, Yoshinori Sato, Rich Felker, Dmitry Torokhov, linux-sh,
linux-kernel, linux-input
On Sun, 21 May 2017, Wolfram Sang wrote:
> include/linux/i2c is not for client devices. Move the header file to a
> more appropriate location.
>
> Signed-off-by: Wolfram Sang <wsa@the-dreams.de>
> ---
> arch/sh/boards/mach-ecovec24/setup.c | 2 +-
> drivers/input/touchscreen/tsc2007_core.c | 2 +-
> drivers/mfd/timberdale.c | 2 +-
Acked-by: Lee Jones <lee.jones@linaro.org>
> include/linux/{i2c => input}/tsc2007.h | 2 +-
> 4 files changed, 4 insertions(+), 4 deletions(-)
> rename include/linux/{i2c => input}/tsc2007.h (95%)
>
> diff --git a/arch/sh/boards/mach-ecovec24/setup.c b/arch/sh/boards/mach-ecovec24/setup.c
> index 6d612792f6b8ec..efca883d3466cc 100644
> --- a/arch/sh/boards/mach-ecovec24/setup.c
> +++ b/arch/sh/boards/mach-ecovec24/setup.c
> @@ -24,7 +24,7 @@
> #include <linux/usb/r8a66597.h>
> #include <linux/usb/renesas_usbhs.h>
> #include <linux/i2c.h>
> -#include <linux/i2c/tsc2007.h>
> +#include <linux/input/tsc2007.h>
> #include <linux/spi/spi.h>
> #include <linux/spi/sh_msiof.h>
> #include <linux/spi/mmc_spi.h>
> diff --git a/drivers/input/touchscreen/tsc2007_core.c b/drivers/input/touchscreen/tsc2007_core.c
> index fc7384936011dc..b680b942e4abde 100644
> --- a/drivers/input/touchscreen/tsc2007_core.c
> +++ b/drivers/input/touchscreen/tsc2007_core.c
> @@ -25,7 +25,7 @@
> #include <linux/input.h>
> #include <linux/interrupt.h>
> #include <linux/i2c.h>
> -#include <linux/i2c/tsc2007.h>
> +#include <linux/input/tsc2007.h>
> #include <linux/of_device.h>
> #include <linux/of_gpio.h>
> #include "tsc2007.h"
> diff --git a/drivers/mfd/timberdale.c b/drivers/mfd/timberdale.c
> index c9339f85359b74..84523b630e2fdf 100644
> --- a/drivers/mfd/timberdale.c
> +++ b/drivers/mfd/timberdale.c
> @@ -32,7 +32,7 @@
> #include <linux/i2c.h>
> #include <linux/i2c-ocores.h>
> #include <linux/i2c-xiic.h>
> -#include <linux/i2c/tsc2007.h>
> +#include <linux/input/tsc2007.h>
>
> #include <linux/spi/spi.h>
> #include <linux/spi/xilinx_spi.h>
> diff --git a/include/linux/i2c/tsc2007.h b/include/linux/input/tsc2007.h
> similarity index 95%
> rename from include/linux/i2c/tsc2007.h
> rename to include/linux/input/tsc2007.h
> index 4f35b6ad3889fa..c7b7eb024328d5 100644
> --- a/include/linux/i2c/tsc2007.h
> +++ b/include/linux/input/tsc2007.h
> @@ -1,7 +1,7 @@
> #ifndef __LINUX_I2C_TSC2007_H
> #define __LINUX_I2C_TSC2007_H
>
> -/* linux/i2c/tsc2007.h */
> +/* linux/input/tsc2007.h */
>
> struct tsc2007_platform_data {
> u16 model; /* 2007. */
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH 4/4] input: tsc2007: move header file out of I2C realm
2017-05-22 7:41 ` Lee Jones
@ 2017-05-22 20:54 ` Dmitry Torokhov
0 siblings, 0 replies; 4+ messages in thread
From: Dmitry Torokhov @ 2017-05-22 20:54 UTC (permalink / raw)
To: Lee Jones
Cc: Wolfram Sang, linux-i2c, Yoshinori Sato, Rich Felker, linux-sh,
linux-kernel, linux-input
On Mon, May 22, 2017 at 08:41:05AM +0100, Lee Jones wrote:
> On Sun, 21 May 2017, Wolfram Sang wrote:
>
> > include/linux/i2c is not for client devices. Move the header file to a
> > more appropriate location.
> >
> > Signed-off-by: Wolfram Sang <wsa@the-dreams.de>
> > ---
> > arch/sh/boards/mach-ecovec24/setup.c | 2 +-
> > drivers/input/touchscreen/tsc2007_core.c | 2 +-
> > drivers/mfd/timberdale.c | 2 +-
>
> Acked-by: Lee Jones <lee.jones@linaro.org>
>
> > include/linux/{i2c => input}/tsc2007.h | 2 +-
> > 4 files changed, 4 insertions(+), 4 deletions(-)
> > rename include/linux/{i2c => input}/tsc2007.h (95%)
This should really go into include/linux/platform_data/, not into
input/, for the same reason you are moving it out of i2c. I'd also like
to get rid of platform data for tsc2007 altogether...
I guess I'll take it (moving to platform_data/) so I can work on generic
properties...
Thanks.
--
Dmitry
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2017-05-22 20:54 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-05-21 20:40 [PATCH 0/4] input: move include files out of include/linux/i2c Wolfram Sang
2017-05-21 20:40 ` [PATCH 4/4] input: tsc2007: move header file out of I2C realm Wolfram Sang
2017-05-22 7:41 ` Lee Jones
2017-05-22 20:54 ` Dmitry Torokhov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).